Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove unused KeyPowerReduction var #10248

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Sep 28, 2021

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@colin-axner colin-axner changed the title chore: remove unused KeyPowerReduction var chore!: remove unused KeyPowerReduction var Sep 28, 2021
@colin-axner colin-axner marked this pull request as ready for review September 28, 2021 10:32
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #10248 (f46934b) into master (e9390df) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10248   +/-   ##
=======================================
  Coverage   63.65%   63.65%           
=======================================
  Files         573      573           
  Lines       53761    53761           
=======================================
+ Hits        34221    34222    +1     
+ Misses      17591    17590    -1     
  Partials     1949     1949           
Impacted Files Coverage Δ
x/staking/types/params.go 37.96% <ø> (ø)
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, thanks. Surely some leftovers from #9495

@robert-zaremba robert-zaremba added A:automerge Automatically merge PR once all prerequisites pass. Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Sep 28, 2021
@robert-zaremba robert-zaremba merged commit 548c986 into master Sep 28, 2021
@robert-zaremba robert-zaremba deleted the colin/staking-unused-var branch September 28, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/staking Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants