Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rosetta getHeight function to use tmRPC.GenesisChunked() instead tmRPC.Genesis() (backport #10340) #10400

Closed
wants to merge 2 commits into from

Commits on Oct 19, 2021

  1. fix: rosetta getHeight function to use tmRPC.GenesisChunked() inste…

    …ad tmRPC.Genesis() (#10340)
    
    <!--
    The default pull request template is for types feat, fix, or refactor.
    For other templates, add one of the following parameters to the url:
    - template=docs.md
    - template=other.md
    -->
    
    ## Description
    
    When we enable rosetta from the chain with non-zero initial height & huge genesis, it always return
    ```
    Error: rosetta: (502) bad gateway
    ```
    
    This is due to huge genesis load rejection from Tendermint.
    
    In current implementation, rosetta server requests genesis to get initial height
    ```
    c.tmRPC.Genesis(ctx)
    ```
    
    but, this will be failed with below message when the genesis is huge
    ```
    {
      "jsonrpc": "2.0",
      "id": -1,
      "error": {
        "code": -32603,
        "message": "Internal error",
        "data": "genesis response is large, please use the genesis_chunked API instead"
      }
    }
    ```
    
    To fix this, we can use following lines
    ```
    status, err := c.tmRPC. GenesisChunked(ctx)
    
    ```
    ---
    
    ### Author Checklist
    
    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*
    
    I have...
    
    - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] added `!` to the type prefix if API or client breaking change
    - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
    - [ ] provided a link to the relevant issue or specification
    - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
    - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
    - [ ] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed
    
    ### Reviewers Checklist
    
    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*
    
    I have...
    
    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)
    
    (cherry picked from commit 6789862)
    
    # Conflicts:
    #	CHANGELOG.md
    #	server/rosetta/client_online.go
    yun-yeo authored and mergify-bot committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    fc08718 View commit details
    Browse the repository at this point in the history
  2. fix conflicts

    tac0turtle committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    bec4d18 View commit details
    Browse the repository at this point in the history