chore: move server.GenerateCoinKey and server.GenerateSaveCoinKey to testutil #10956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Cosmovisor
robert-zaremba
removed
C:x/capability
C:x/genutil
19 tasks
|
Let's also solve dep cycles here |
|
let's reach the consensus if we can do this: #10957 (comment) |
robert-zaremba
commented
Jan 17, 2022
| func GenerateSaveCoinKey( | ||
| keybase keyring.Keyring, | ||
| keyName, mnemonic string, | ||
| keyName string, |
There was a problem hiding this comment.
we decided to rollback the api breaking, deprecate this function and move it with the mnemonic feature to testutil package.
alexanderbez
approved these changes
Jan 17, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jan 18, 2022
#10957) Cleaning it and moving the breaking "test" code to testutils Related to: #10956 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
JimLarson
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Jul 7, 2022
…testutil (cosmos#10956) * chore: move server.GenerateCoinKey and server.GenerateSaveCoinKey to testutil * add changelog * move testutil/known_values.go to testutil/testdata * changelog
Eengineer1
pushed a commit
to cheqd/cosmos-sdk
that referenced
this pull request
Aug 26, 2022
…testutil (cosmos#10956) * chore: move server.GenerateCoinKey and server.GenerateSaveCoinKey to testutil * add changelog * move testutil/known_values.go to testutil/testdata * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A breaking change was backported to 0.45 RC: #10934
Cleaning it and moving the breaking "test" code to testutils
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change