feat: remove burning of deposits in gov - #11011
Conversation
cmwaters
left a comment
cmwaters
left a comment
There was a problem hiding this comment.
This makes sense to me but maybe we'll want to pass this by one or two others. I think we'll need to update the specification as well to make the new behaviour clear.
| @@ -20,7 +20,7 @@ func EndBlocker(ctx sdk.Context, keeper keeper.Keeper) { | |||
| // delete dead proposals from store and burn theirs deposits. A proposal is dead when it's inactive and didn't get enough deposit on time to get into voting phase. | |||
There was a problem hiding this comment.
need to update the comment here as well
ValarDragon
left a comment
ValarDragon
left a comment
There was a problem hiding this comment.
LGTM, this has imo been a bug for awhile.
|
gonna mark this as draft for a little as its not clear if this approach wants to be taken. |
| keeper.IterateInactiveProposalsQueue(ctx, ctx.BlockHeader().Time, func(proposal v1beta2.Proposal) bool { | ||
| keeper.DeleteProposal(ctx, proposal.ProposalId) | ||
| keeper.DeleteAndBurnDeposits(ctx, proposal.ProposalId) | ||
| keeper.RefundAndDeleteDeposits(ctx, proposal.ProposalId) // refund deposit if proposal got removed without getting 100% of the proposal |
There was a problem hiding this comment.
Let's add a state-machine breaking changelog
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
LGTM, pending changelog
|
Also, there's an out-of-gas error in sims, we might need to bump tx fees somewhere. |
|
do we need a gov proposal to revert this since we had one to make the change https://hubble.figment.io/cosmos/chains/cosmoshub-2/governance/proposals/6 |
this bug was non-determinism in the non-determinism test. I can't reproduce locally and cli seems to not be able to reproduce. |
|
I think this shouldn't be merged - there was no consensus in the issue. |
deposit burn behaviour was changed in cosmos/cosmos-sdk#11011
* burn deposit documentation update deposit burn behaviour was changed in cosmos/cosmos-sdk#11011 * Update docs/governance/process.md
* burn deposit documentation update deposit burn behaviour was changed in cosmos/cosmos-sdk#11011 * Update docs/governance/process.md
6 participants
Description
Closes: #11010
only burn deposits on veto'd proposals/
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change