Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add RegisterLegacyAminoCodec for authz/feegrant #11214

Closed
wants to merge 3 commits into from

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Feb 17, 2022

Description

Closes: #11190


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 marked this pull request as draft February 17, 2022 17:07
@RiccardoM
Copy link
Contributor

Just a reminder: there is also the need to implement Amino serialization for the Authorization interface and all its implementations. Also the Amino codec needs to be created and used when serializing the messages (same as what happens inside other modules). If you want I can help you with that tomorrow @AmauryM

msg = &authz.MsgExec{Grantee: "cosmos1def", Msgs: []*cdctypes.Any{msgSendAny}}
tx.Msgs = []sdk.Msg{msg}
require.Equal(t,
`{"account_number":"1","chain_id":"foo","fee":{"amount":[],"gas":"0"},"memo":"memo","msgs":[{"type":"cosmos-sdk/authz/MsgExec","value":{"grantee":"cosmos1def","msgs":[{"amount":[],"from_address":"cosmos1ghi","to_address":"cosmos1jkl"}]}}],"sequence":"1","timeout_height":"1"}`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: for nested Msgs, Amino doesn't show their type/value pair. That's because we use a local ModuleCdc to do msg.GetSignBytes, and this local ModuleCdc isn't aware of other modules' amino registrations. I think it's fine, as long as the top-level Msg has a type/value.

@amaury1093
Copy link
Contributor Author

amaury1093 commented Feb 17, 2022

@RiccardoM Oh yeah, that sounds good! I have some other work to do on gov/group, so would love if you can finish this PR. (Feel free to push here, or close it and open a new one if you want)

@RiccardoM
Copy link
Contributor

@AmauryM Created #11224 which implements everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/authz and x/feegrant don't support ledger signing
2 participants