Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(errors): add wrapped errors messages in grpcstatus #11714

Merged
merged 5 commits into from
Apr 21, 2022

Conversation

julienrbrt
Copy link
Member

Description

ref: #11406

The tests in the above PR are failing because of the new GRPCStatus definition for wrapped errors.
It was losing the wrapped message and making the test fail.

Once merged, please tag a new version of the errors package.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #11714 (c7ce697) into master (f421b95) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11714      +/-   ##
==========================================
+ Coverage   65.93%   66.00%   +0.06%     
==========================================
  Files         667      671       +4     
  Lines       70460    70727     +267     
==========================================
+ Hits        46460    46684     +224     
- Misses      21304    21337      +33     
- Partials     2696     2706      +10     
Impacted Files Coverage Δ
errors/errors.go 83.46% <100.00%> (ø)
errors/handle.go 0.00% <0.00%> (ø)
errors/abci.go 89.09% <0.00%> (ø)
errors/stacktrace.go 84.14% <0.00%> (ø)

@julienrbrt julienrbrt assigned blushi and unassigned blushi Apr 21, 2022
@alexanderbez alexanderbez added A:automerge Automatically merge PR once all prerequisites pass. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. labels Apr 21, 2022
@mergify mergify bot merged commit d6b3fa5 into master Apr 21, 2022
@mergify mergify bot deleted the julien/errors-grpcstatus branch April 21, 2022 14:26
@julienrbrt
Copy link
Member Author

@aaronc could you please tag the beta5 of the errors package? :)

@aaronc
Copy link
Member

aaronc commented Apr 21, 2022

@aaronc could you please tag the beta5 of the errors package? :)

Tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants