Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: tweak x/gov ModuleAccountInvariant #11998

Merged
merged 5 commits into from May 20, 2022
Merged

chore!: tweak x/gov ModuleAccountInvariant #11998

merged 5 commits into from May 20, 2022

Conversation

alexanderbez
Copy link
Contributor

Description

Tweak the ModuleAccountInvariant x/gov invariant s.t. funds can be sent directly to the x/gov module account (which also includes community pool spends where the recipient is the x/gov module account).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez requested a review from a team as a code owner May 19, 2022 15:12
@alexanderbez alexanderbez changed the title chore: tweak x/gov ModuleAccountInvariant chore!: tweak x/gov ModuleAccountInvariant May 19, 2022
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need an Improvement entry in the changelog?

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog entry please

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #11998 (6d14b1e) into main (01832e6) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11998      +/-   ##
==========================================
- Coverage   66.03%   65.99%   -0.04%     
==========================================
  Files         674      670       -4     
  Lines       71130    70871     -259     
==========================================
- Hits        46969    46772     -197     
+ Misses      21497    21444      -53     
+ Partials     2664     2655       -9     
Impacted Files Coverage Δ
errors/abci.go
errors/errors.go
errors/stacktrace.go
errors/handle.go
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️
x/distribution/simulation/operations.go 90.10% <0.00%> (+9.89%) ⬆️

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/gov
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants