chore: sdk.Int to math.Int

[faddat]

Description

When locally working with golangci-lint, we can see that there were many deprecation warnings about sdk.Int. This PR resolves that and makes 1-2 other linting related changes. Issue on linting coming next.

This also moves BitCurve to bitCurve.

I expect that this set of changes will require several pull requests, one of them to the settings for the linter.

It also does a gofumpt, because we had various formatting-related linters fail, too.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #12132 (237e36f) into main (889dfcb) will increase coverage by 0.33%.
The diff coverage is 56.73%.

@@            Coverage Diff             @@
##             main   #12132      +/-   ##
==========================================
+ Coverage   66.04%   66.38%   +0.33%     
==========================================
  Files         671      686      +15     
  Lines       71055    72102    +1047     
==========================================
+ Hits        46927    47863     +936     
- Misses      21465    21543      +78     
- Partials     2663     2696      +33     

Impacted Files	Coverage Δ
baseapp/baseapp.go	79.27% <ø> (ø)
client/cmd.go	57.73% <0.00%> (ø)
client/grpc_query.go	30.33% <0.00%> (ø)
client/keys/add.go	63.34% <0.00%> (ø)
core/appconfig/config.go	80.95% <ø> (ø)
pruning/manager.go	95.18% <ø> (ø)
server/mock/tx.go	63.15% <ø> (ø)
server/rosetta/converter.go	56.28% <0.00%> (ø)
simapp/test_helpers.go	26.34% <0.00%> (ø)
testutil/network/network.go	62.40% <ø> (ø)
... and 62 more

[faddat]

codecov is a red herring factory.

[julienrbrt]

Great clean up, thanks! Just one comment.

[faddat]

When this PR is merged, all of the other PR's in the linting series of PR's should also become easier to review.

Thanks @julienrbrt

[tac0turtle]

lgtm, left one comment on import grouping

[ValarDragon]

Wait no, why did we apply changes to the secp curve code? That should not be changed, its a copy of code elsewhere, that we do not changed. (Its a valid question if it should be its own repo)

But applying lint changes to it does not seem like a good idea imo, adds noise to diffs against upstream.

[julienrbrt]

Wait no, why did we apply changes to the secp curve code? That should not be changed, its a copy of code elsewhere, that we do not changed. (Its a valid question if it should be its own repo)

But applying lint changes to it does not seem like a good idea imo, adds noise to diffs against upstream.

Good point, but it does add noise to the tooling to specifically ignore that file 🤷🏾‍♂️
Maybe its own repo is overkill, but it does make sense if it should be a read-only file.
cc @marbar3778