Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use canonical golangci-lint github action #12134

Closed
wants to merge 39 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
d952235
Update lint.yml
faddat Jun 3, 2022
400fef3
fix suspicious join by using .Dir instead of .Join
faddat Jun 3, 2022
960919a
Merge branch 'main' into suspicious-join
faddat Jun 3, 2022
9dffa36
Update CHANGELOG.md
faddat Jun 3, 2022
edc57bb
Update .github/workflows/lint.yml
faddat Jun 3, 2022
4118316
Update .github/workflows/lint.yml
faddat Jun 3, 2022
9db408c
Update CHANGELOG.md
faddat Jun 3, 2022
0b66c4d
Merge branch 'main' into patch-9
faddat Jun 3, 2022
241a808
Merge branch 'main' into patch-9
faddat Jun 3, 2022
3e991f1
Merge branch 'main' into patch-9
faddat Jun 3, 2022
f022bd3
Merge branch 'main' into patch-9
faddat Jun 3, 2022
75ef457
Merge branch 'main' into patch-9
faddat Jun 3, 2022
d801c2f
Merge branch 'main' into patch-9
faddat Jun 3, 2022
d2cabb0
Update CHANGELOG.md
faddat Jun 3, 2022
30cb49a
Merge branch 'main' into patch-9
faddat Jun 7, 2022
9847ac8
Merge branch 'main' into patch-9
tac0turtle Jun 8, 2022
b08f344
Merge branch 'main' into patch-9
faddat Jun 8, 2022
deffbbc
Merge branch 'main' into patch-9
tac0turtle Jun 8, 2022
ea5438d
Merge branch 'main' into patch-9
faddat Jun 8, 2022
26036ef
Merge branch 'main' into patch-9
faddat Jun 9, 2022
95ac2de
Merge remote-tracking branch 'notional/suspicious-join' into HEAD
faddat Jun 9, 2022
075af32
Merge branch 'main' into patch-9
faddat Jun 9, 2022
a6f1498
fix fliepath issues in simapp
faddat Jun 9, 2022
18835a4
Merge branch 'patch-9' of https://github.com/faddat/basecoin into pat…
faddat Jun 9, 2022
bd5667e
Merge branch 'main' into patch-9
faddat Jun 9, 2022
18becdf
unfix suspicious join in testnet.go
faddat Jun 9, 2022
d382053
Merge branch 'patch-9' of https://github.com/faddat/basecoin into pat…
faddat Jun 9, 2022
388eff7
Merge branch 'main' into patch-9
faddat Jun 9, 2022
6b97db8
Merge branch 'patch-9' of https://github.com/faddat/basecoin into pat…
faddat Jun 9, 2022
ca29bf1
revert changes from fix suspicious join
faddat Jun 9, 2022
a53a342
I have marked two suspicious joins as nolint. There is a solution an…
faddat Jun 9, 2022
8961afe
Update lint.yml
faddat Jun 9, 2022
a503ef7
fumpt x/slashing/module.go
faddat Jun 9, 2022
c16f56e
Merge branch 'patch-9' of https://github.com/faddat/basecoin into pat…
faddat Jun 9, 2022
3ae1cc6
Merge branch 'main' into patch-9
faddat Jun 10, 2022
9e1cbb4
Merge branch 'main' into patch-9
faddat Jun 10, 2022
d78d968
fumpt
faddat Jun 10, 2022
0461757
Delete .gitpod.yml
faddat Jun 13, 2022
24c2175
Merge branch 'main' into patch-9
faddat Jun 20, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
59 changes: 33 additions & 26 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,41 +1,48 @@
name: Lint
# Lint runs golangci-lint over the entire cosmos-sdk repository
# This workflow is run on every pull request and push to main
# The `golangci` will pass without running if no *.{go, mod, sum} files have been changed.
name: golangci-lint
on:
pull_request:
push:
tags:
- v*
branches:
- master
faddat marked this conversation as resolved.
Show resolved Hide resolved
- main
pull_request:
permissions:
contents: read
# Optional: allow read access to pull request. Use with `only-new-issues` option.
# pull-requests: read
jobs:
golangci:
name: golangci-lint
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v3
with:
go-version: 1.18
- uses: technote-space/get-diff-action@v6.0.1
id: git_diff
with:
PATTERNS: |
**/**.go
go.mod
go.sum
Comment on lines -18 to -24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually opt to have this to not run this position of ci when there are no changes to the go code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend that we run it all the time since the compute to do that costs nothing and the previous setup resulted in not linting at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But there's no sense in running it if there are zero code changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I can roll with it, I’ll make that change I’m just worried that I could introduce another bug that reproduces the prior state

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this change, after this we can look at merging

- name: Get data from Go build cache
# if: env.GIT_DIFF
if: ${{ false }}
uses: actions/cache@v3
with:
path: |
~/go/pkg/mod
~/.cache/golangci-lint
~/.cache/go-build
key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }}
- uses: actions/checkout@v3
- name: golangci-lint
if: env.GIT_DIFF
uses: golangci/golangci-lint-action@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to migrate away from this action since it doesn't support workspaces or multiple go.mods in a single repo for now.

with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: latest
args: --out-format=tab
skip-go-installation: true
# Generally in cosmos, we don't use the latest version of linting software, and this is bad because the linters are another layer of protection against bugs and errors.
# Therefore, when attempting to standardize, we allow the version of the linters to "roll" and accept that breakages may occur because of this and require fixing.

# Optional: working directory, useful for monorepos
# working-directory: somedir

# Optional: golangci-lint command line arguments.
# args: --issues-exit-code=0

# Optional: show only new issues if it's a pull request. The default value is `false`.
# only-new-issues: true

# Optional: if set to true then the all caching functionality will be complete disabled,
# takes precedence over all other caching options.
# skip-cache: true

# Optional: if set to true then the action don't cache or restore ~/go/pkg.
# skip-pkg-cache: true

# Optional: if set to true then the action don't cache or restore ~/.cache/go-build.
# skip-build-cache: true
faddat marked this conversation as resolved.
Show resolved Hide resolved