Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto gas don't work #12590

Merged
merged 8 commits into from Jul 16, 2022
Merged

fix: auto gas don't work #12590

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
adaa3a8
Problem: auto gas don't work
yihuang Jul 15, 2022
5813149
don't check gas price in simulation mode
yihuang Jul 15, 2022
15320c4
update changelog
yihuang Jul 15, 2022
a7ef88c
add unit tests
yihuang Jul 15, 2022
6f4709b
Merge branch 'main' into main
alexanderbez Jul 15, 2022
9cde1e4
Update x/auth/ante/fee.go
yihuang Jul 16, 2022
4919f4d
Update x/auth/ante/fee.go
julienrbrt Jul 16, 2022
a24340e
Merge branch 'main' into main
mergify[bot] Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -51,6 +51,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* [#12187](https://github.com/cosmos/cosmos-sdk/pull/12187) Add batch operation for x/nft module.
* [#12453](https://github.com/cosmos/cosmos-sdk/pull/12453) Add `NewInMemoryWithKeyring` function which allows the creation of in memory `keystore` instances with a specified set of existing items.
* [#11390](https://github.com/cosmos/cosmos-sdk/pull/11390) `LatestBlockResponse` & `BlockByHeightResponse` types' `Block` filed has been deprecated and they now contains new field `sdk_block` with `proposer_address` as `string`
* [#12589](https://github.com/cosmos/cosmos-sdk/pull/12589) Allow zero gas in simulation mode.
julienrbrt marked this conversation as resolved.
Show resolved Hide resolved

### State Machine Breaking

Expand Down
2 changes: 1 addition & 1 deletion x/auth/ante/fee.go
View file
Open in desktop
Expand Up @@ -42,7 +42,7 @@ func (dfd DeductFeeDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bo
return ctx, sdkerrors.Wrap(sdkerrors.ErrTxDecode, "Tx must be a FeeTx")
}

if ctx.BlockHeight() > 0 && feeTx.GetGas() == 0 {
if !simulate && ctx.BlockHeight() > 0 && feeTx.GetGas() == 0 {
return ctx, sdkerrors.Wrap(sdkerrors.ErrInvalidGasLimit, "must provide positive gas")
}

Expand Down