Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect versions of imported protos in Makefile #12701

Merged
merged 7 commits into from Jul 25, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jul 23, 2022

Description

This modifies the Makefile to ensure that we are fetching the correct version of imported .proto files.

Tendermint and ics23 were wrong.

It also does a nice old-fashioned "make proto-gen" for good measure.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner July 23, 2022 10:21
@faddat faddat changed the title bug: fix versions of imported protos in Makefile fix: fix versions of imported protos in Makefile Jul 23, 2022
@faddat faddat changed the title fix: fix versions of imported protos in Makefile fix: incorrect versions of imported protos in Makefile Jul 23, 2022
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@julienrbrt
Copy link
Member

julienrbrt commented Jul 23, 2022

Can we do the same thing for main? :)

CHANGELOG.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
faddat and others added 4 commits July 26, 2022 04:21
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@faddat
Copy link
Contributor Author

faddat commented Jul 25, 2022

Sure, can do the same thing for main :)

@alexanderbez alexanderbez merged commit f11cf53 into cosmos:release/v0.46.x Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants