Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: printf for Record protobuf #13145

Merged
merged 3 commits into from
Sep 6, 2022
Merged

fix: printf for Record protobuf #13145

merged 3 commits into from
Sep 6, 2022

Conversation

raynaudoe
Copy link
Contributor

@raynaudoe raynaudoe commented Sep 3, 2022

Description

Closes: #11368


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests //Not applicable
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code //Not applicable
  • updated the relevant documentation or specification //Not applicable
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #13145 (6040567) into main (4fe7797) will decrease coverage by 2.16%.
The diff coverage is 47.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13145      +/-   ##
==========================================
- Coverage   55.87%   53.71%   -2.17%     
==========================================
  Files         646      645       -1     
  Lines       54895    55258     +363     
==========================================
- Hits        30675    29681     -994     
- Misses      21762    23200    +1438     
+ Partials     2458     2377      -81     
Impacted Files Coverage Δ
baseapp/abci.go 67.01% <0.00%> (+2.59%) ⬆️
baseapp/baseapp.go 77.93% <ø> (+1.06%) ⬆️
baseapp/options.go 69.23% <ø> (+0.71%) ⬆️
client/context.go 55.37% <0.00%> (-0.91%) ⬇️
client/flags/flags.go 19.35% <0.00%> (-0.32%) ⬇️
client/rpc/status.go 66.66% <ø> (ø)
client/utils.go 34.92% <0.00%> (ø)
crypto/keys/secp256k1/secp256k1.go 88.63% <ø> (ø)
server/config/config.go 38.00% <0.00%> (-1.59%) ⬇️
server/mock/store.go 19.00% <0.00%> (-0.39%) ⬇️
... and 137 more

@raynaudoe raynaudoe marked this pull request as ready for review September 3, 2022 13:37
@raynaudoe raynaudoe requested a review from a team as a code owner September 3, 2022 13:37
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you touch on why this fixes the issue at hand? Gogoproto issue?

@raynaudoe
Copy link
Contributor Author

Could you touch on why this fixes the issue at hand? Gogoproto issue?

I've updated the issue with some more details #11368 (comment)

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting issue

@tac0turtle tac0turtle enabled auto-merge (squash) September 6, 2022 13:20
@tac0turtle tac0turtle merged commit d47970d into main Sep 6, 2022
@tac0turtle tac0turtle deleted the fix_record_printf branch September 6, 2022 13:35
@ainhoa-a ainhoa-a mentioned this pull request Oct 20, 2022
20 tasks
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
* Disable gogoproto_import for record pb

* Update changelog

Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyring API doesn't work as expected
2 participants