Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp(keyring): improve UX for keyring.List #13369

Merged
merged 6 commits into from
Sep 27, 2022
Merged

imp(keyring): improve UX for keyring.List #13369

merged 6 commits into from
Sep 27, 2022

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Sep 23, 2022 •
edited
Loading

Description

Similar implementation as #13207 but for v0.45.x. This PR improves the UX for the keyring list command by printing all the keys that have already been obtained.

Ref: #10875

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@fedekunze fedekunze marked this pull request as ready for review September 23, 2022 09:39
@fedekunze fedekunze added T: UX C:Keys Keybase, KMS and HSMs labels Sep 23, 2022
@fedekunze fedekunze self-assigned this Sep 23, 2022
@github-actions github-actions bot removed the C:Keys Keybase, KMS and HSMs label Sep 23, 2022
@tac0turtle tac0turtle merged commit 24e405e into release/v0.45.x Sep 27, 2022
@tac0turtle tac0turtle deleted the fedekunze/fix-keys-list branch September 27, 2022 23:25
@aaronc
Copy link
Member

aaronc commented Sep 28, 2022

Do we verify semantic commits now? Pretty sure imp isn't a valid prefix. Should be feat probably

@julienrbrt
Copy link
Member

Do we verify semantic commits now? Pretty sure imp isn't a valid prefix. Should be feat probably

Right, it wasn't https://github.com/cosmos/cosmos-sdk/actions/runs/3112841174/jobs/5046723158. The action isn't marked required however.

@aaronc
Copy link
Member

aaronc commented Sep 28, 2022

Do we verify semantic commits now? Pretty sure imp isn't a valid prefix. Should be feat probably

Right, it wasn't https://github.com/cosmos/cosmos-sdk/actions/runs/3112841174/jobs/5046723158. The action isn't marked required however.

I'd say we require it. I don't see a lot of harm in doing that

@alexanderbez
Copy link
Contributor

I'm going to require it.

@alexanderbez
Copy link
Contributor

Marked Lint PR / main as required. Note, the actual job is called is called main, which is not really useful. We should rename it to something like lint-pr.

MissingNO57 added a commit to fetchai/cosmos-sdk that referenced this pull request Nov 30, 2022
@MissingNO57
Merge pull request #135 from fetchai/upgrade_v0.45.9
487cff7 
## v0.45.9 - 2022-10-14

ATTENTION:

This is a security release for the 
[Dragonberry security advisory](https://forum.cosmos.network/t/ibc-security-advisory-dragonberry/7702). 

All users should upgrade immediately.

Users *must* add a replace directive in their go.mod for the
new `ics23` package in the SDK:

```
replace (
    github.com/confio/ics23/go => github.com/cosmos/cosmos-sdk/ics23
)

```

### Features

* [#13435](cosmos/cosmos-sdk#13435) Extend error context when a simulation fails.

### Improvements

* [#13369](cosmos/cosmos-sdk#13369) Improve UX for `keyring.List` by returning all retrieved keys.
* [#13323](cosmos/cosmos-sdk#13323) Ensure `withdraw_rewards` rewards are emitted from all actions that result in rewards being withdrawn.
* [#13321](cosmos/cosmos-sdk#13321) Add flag to disable fast node migration and usage.
* (store) [#13326](cosmos/cosmos-sdk#13326) Implementation of ADR-038 file StreamingService, backport #8664.
* (store) [#13540](cosmos/cosmos-sdk#13540) Default fastnode migration to false to prevent suprises. Operators must enable it, unless they have it enabled already. 

### API Breaking Changes

* (cli) [#13089](cosmos/cosmos-sdk#13089) Fix rollback command don't actually delete multistore versions, added method `RollbackToVersion` to interface `CommitMultiStore` and added method `CommitMultiStore` to `Application` interface.

### Bug Fixes

* [#...](https://github.com/cosmos/cosmos-sdk/pull/) Implement dragonberry security patch.
  * For applying the patch please refer to the [RELEASE NOTES](./RELEASE_NOTES.md)
* (store) [#13459](cosmos/cosmos-sdk#13459) Don't let state listener observe the uncommitted writes.
@faddat faddat mentioned this pull request Dec 11, 2023
Draft
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@julienrbrt julienrbrt julienrbrt left review comments

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees

@fedekunze fedekunze

Labels
T: UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fedekunze @aaronc @julienrbrt @alexanderbez @tac0turtle