fix: all: remove map iteration non-determinism with keys + sorting #13377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kind ping to @marbar3778 @julienrbrt @alexanderbez and FYI to @elias-orijtech @willpoint |
odeke-em
force-pushed
the
fix-reduce-map-iteration-non-determinism-with-keys+sorting
branch
2 times, most recently
from
b06455f
to
f5cde85
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13377 +/- ##
==========================================
+ Coverage 54.14% 54.97% +0.82%
==========================================
Files 651 674 +23
Lines 56055 57520 +1465
==========================================
+ Hits 30353 31623 +1270
+ Misses 23280 23246 -34
- Partials 2422 2651 +229
|
Fixes some errors flagged by cosmos/gosec like: * https://github.com/cosmos/cosmos-sdk/security/code-scanning/760 * https://github.com/cosmos/cosmos-sdk/security/code-scanning/765 * https://github.com/cosmos/cosmos-sdk/security/code-scanning/767 * https://github.com/cosmos/cosmos-sdk/security/code-scanning/774 * https://github.com/cosmos/cosmos-sdk/security/code-scanning/776 * https://github.com/cosmos/cosmos-sdk/security/code-scanning/815
odeke-em
force-pushed
the
fix-reduce-map-iteration-non-determinism-with-keys+sorting
branch
from
f5cde85
to
63ff150
Compare
julienrbrt
deleted the
fix-reduce-map-iteration-non-determinism-with-keys+sorting
branch
Wryhder
pushed a commit
to Wryhder/cosmos-sdk
that referenced
this pull request
Oct 26, 2022
5 tasks
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some errors flagged by cosmos/gosec like: