Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move simapp.App to runtime.AppI #13378

Merged
merged 6 commits into from
Sep 24, 2022
Merged

Conversation

julienrbrt
Copy link
Member

Description

Move simapp.App to runtime.AppI, as chains should not import simapp anymore.
ref: #13376 (comment)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner September 24, 2022 08:40
@julienrbrt julienrbrt mentioned this pull request Sep 24, 2022
19 tasks
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Merging #13378 (fa4d1ba) into main (af81605) will decrease coverage by 1.98%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13378      +/-   ##
==========================================
- Coverage   56.12%   54.14%   -1.99%     
==========================================
  Files         713      651      -62     
  Lines       60174    56055    -4119     
==========================================
- Hits        33774    30349    -3425     
+ Misses      23642    23281     -361     
+ Partials     2758     2425     -333     
Impacted Files Coverage Δ
simapp/app.go 77.30% <ø> (ø)
simapp/utils.go 21.91% <0.00%> (ø)
x/staking/simulation/operations.go 74.54% <0.00%> (-1.38%) ⬇️
tx/textual/valuerenderer/valuerenderer.go
orm/encoding/ormfield/codec.go
orm/model/ormtable/singleton.go
orm/model/ormdb/json.go
depinject/module_key.go
depinject/internal/codegen/file.go
orm/model/ormtable/auto_increment.go
... and 79 more

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get an entry in upgrading.md

@julienrbrt
Copy link
Member Author

can we get an entry in upgrading.md

Sure thing, added!

@tac0turtle tac0turtle enabled auto-merge (squash) September 24, 2022 11:37
@tac0turtle tac0turtle merged commit b76f338 into main Sep 24, 2022
@tac0turtle tac0turtle deleted the julien/app-interface branch September 24, 2022 11:49
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
* refactor: move `simapp.App` to `runtime.AppI`

* add changelog

* `go mod tidy`

* fix app legacy build
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* refactor: move `simapp.App` to `runtime.AppI`

* add changelog

* `go mod tidy`

* fix app legacy build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants