fix: types: remove unnecessary/pedantic code from removeZeroCoins #13967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies and makes clearer the code in removeZeroCoins by removing unnecessary checks that boiled down to still running in the same final for loop. Fixes #13958
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13967 +/- ##
==========================================
- Coverage 56.35% 56.22% -0.13%
==========================================
Files 676 667 -9
Lines 56989 56576 -413
==========================================
- Hits 32115 31811 -304
+ Misses 22261 22184 -77
+ Partials 2613 2581 -32 |
julienrbrt
approved these changes
Nov 22, 2022
atheeshp
approved these changes
Nov 22, 2022
tac0turtle
approved these changes
Nov 22, 2022
tac0turtle
deleted the
types-remove-unnecessary-code-from-removeZeroCoins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies and makes clearer the code in removeZeroCoins by removing unnecessary checks that boiled down to still running in the same final for loop.
Fixes #13958