Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime: fix (*App).RegisterMoodules inconsistency in checking/memoizing appModule #14128

Merged

Commits on Dec 1, 2022

  1. fix: runtime: fix (*App).RegisterMoodules inconsistency in checking/m…

    …emoizing appModule
    
    Fixes an inconsistency in checking for duplicates in ModuleManager's
    Modules[name] then also basicManager[name] in which memoization could
    happen for .Module[name] but fail after a duplicate check in
    basicManager[name]. This change instead only memoizes the AppModule
    after the duplicate checks have all cleared.
    
    Fixes #14006
    odeke-em committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    ce825ed View commit details
    Browse the repository at this point in the history