Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(context): Update Ctx Event Manager modifier to take interface #14396

Closed

Conversation

calbera
Copy link
Contributor

@calbera calbera commented Dec 22, 2022

Description

Followup to #14384, one-liner necessary change
Allows chains to modify the context event manager with their own

@itsdevbear


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@calbera calbera requested a review from a team as a code owner December 22, 2022 19:34
@itsdevbear
Copy link
Contributor

tldr we're goofies

@julienrbrt julienrbrt enabled auto-merge (squash) December 23, 2022 21:15
@julienrbrt
Copy link
Member

Could you please rebase, or allow maintainer to do so?

@tac0turtle
Copy link
Member

replacing with #14418 to get it merged

@tac0turtle tac0turtle closed this Dec 26, 2022
auto-merge was automatically disabled December 26, 2022 14:09

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants