refactor: remove base app from store #14417
Conversation
github-prbot
requested review from
a team,
facundomedica and
julienrbrt
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| import ( | ||
| "reflect" | ||
| "unsafe" |
Check failure
Code scanning / gosec
Blocklisted import unsafe
| package conv | ||
|
|
||
| import ( | ||
| "reflect" |
Check failure
Code scanning / gosec
Blocklisted import unsafe
| for key, lis := range streamer.Listeners() { | ||
| app.cms.AddListeners(key, lis) | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
| // to be used generally, but for a specific pattern to delete keys | ||
| // from a map. | ||
| func UnsafeBytesToStr(b []byte) string { | ||
| return *(*string)(unsafe.Pointer(&b)) |
Check warning
Code scanning / gosec
Use of unsafe calls should be audited
| func UnsafeStrToBytes(s string) []byte { | ||
| var buf []byte | ||
| sHdr := (*reflect.StringHeader)(unsafe.Pointer(&s)) | ||
| bufHdr := (*reflect.SliceHeader)(unsafe.Pointer(&buf)) |
Check warning
Code scanning / gosec
Use of unsafe calls should be audited
| // must not be altered after this function is called as it will cause a segmentation fault. | ||
| func UnsafeStrToBytes(s string) []byte { | ||
| var buf []byte | ||
| sHdr := (*reflect.StringHeader)(unsafe.Pointer(&s)) |
Check warning
Code scanning / gosec
Use of unsafe calls should be audited
| for key, lis := range streamer.Listeners() { | ||
| app.cms.AddListeners(key, lis) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
| package conv | ||
|
|
||
| import ( | ||
| "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import
|
|
||
| import ( | ||
| "reflect" | ||
| "unsafe" |
Check notice
Code scanning / CodeQL
Sensitive package import
|
[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed!
|
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!
|
julienrbrt
added
the
A:automerge
## Description This pr removes base app from the store package. This is un order to decouple store from the sdk. There are a few things we can clean up but the telemetry package may be difficult with how it's done. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Description
This pr removes base app from the store package. This is un order to decouple store from the sdk. There are a few things we can clean up but the telemetry package may be difficult with how it's done.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change