Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Integrate tendermint Block endpoints into the cli #14659

Merged
merged 66 commits into from
Feb 14, 2023
Merged

feat: Integrate tendermint Block endpoints into the cli #14659

merged 66 commits into from
Feb 14, 2023

Conversation

cipherzzz
Copy link
Contributor

@cipherzzz cipherzzz commented Jan 17, 2023 •
edited
Loading

Description

Closes: #13703

This PR

  • Adds a query by hash function to the existing query by block height call
  • proxies the BlockSearch tendermint api and returns the resulting blocks .

See usage below.

I have just tested it in the simd env

# build
make build

# Start chain
./build/simd start

# query by height
 ./build/simd q block --type=height <height>

# query by hash
 ./build/simd q block --type=hash <hash>

# query by event
./build/simd q blocks --query "transfer.recipient='cosmos...' AND block.height > 7" --page 1 --limit 30

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests - I'm not seeing any tests for the cli?
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@cipherzzz cipherzzz requested a review from a team as a code owner January 17, 2023 20:20
@cipherzzz cipherzzz marked this pull request as draft January 17, 2023 20:20
@github-prbot github-prbot requested review from a team, JeancarloBarrios and tac0turtle and removed request for a team January 17, 2023 20:20
@cipherzzz cipherzzz changed the title idiot check feat: Integrate tendermint Block endpoints into the cli Jan 17, 2023
@cipherzzz cipherzzz changed the title feat: Integrate tendermint Block endpoints into the cli !feat: Integrate tendermint Block endpoints into the cli Jan 17, 2023
cipherzzz
cipherzzz commented Jan 17, 2023
View reviewed changes
client/tendermint.go Outdated Show resolved Hide resolved
cipherzzz
cipherzzz commented Jan 17, 2023
View reviewed changes
simapp/simd/cmd/root.go Outdated Show resolved Hide resolved
cipherzzz
cipherzzz commented Jan 17, 2023
View reviewed changes
x/auth/client/cli/query.go Outdated Show resolved Hide resolved
cipherzzz
cipherzzz commented Jan 17, 2023
View reviewed changes
x/auth/client/cli/query.go Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 17, 2023
View reviewed changes
x/auth/client/cli/query.go Fixed Show fixed Hide fixed
@cipherzzz cipherzzz changed the title !feat: Integrate tendermint Block endpoints into the cli feat: Integrate tendermint Block endpoints into the cli Jan 19, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 20, 2023
View reviewed changes
x/auth/block/query.go Fixed Show resolved Hide resolved
x/auth/block/query.go Fixed Show resolved Hide resolved
x/auth/block/query.go Fixed Show resolved Hide resolved
types/result.go Fixed Show resolved Hide resolved
x/auth/client/cli/query.go Fixed Show resolved Hide resolved
x/auth/client/cli/query.go Fixed Show resolved Hide resolved
x/auth/client/cli/query.go Fixed Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 20, 2023
View reviewed changes
types/result.go Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2023
View reviewed changes
types/result.go Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2023
View reviewed changes
types/result.go Fixed Show fixed Hide fixed
cipherzzz and others added 10 commits February 8, 2023 20:59
@cipherzzz
Merge branch 'main' of github.com:cosmos/cosmos-sdk into cipherz/1370…
763119e 
…3-query-block-event
@cipherzzz @julienrbrt
Update types/result.go
4bea8b3 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@cipherzzz @julienrbrt
Update client/rpc/block.go
4310491 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@cipherzzz @julienrbrt
Update server/cmt_cmds.go
bedce2d 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@cipherzzz @julienrbrt
Update server/cmt_cmds.go
01bdbe3 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@cipherzzz @julienrbrt
Update server/cmt_cmds.go
4af5760 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@cipherzzz @julienrbrt
Update server/cmt_cmds.go
fb5857d 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@cipherzzz
updates per pr feedback
1b3eb73
@cipherzzz
Merge branch 'cipherz/13703-query-block-event' of github.com:cipherzz…
1e1cf9d 
…z/cosmos-sdk-fork into cipherz/13703-query-block-event
@cipherzzz
updates per PR feedback
35669ab
@github-actions github-actions bot removed the C:x/bank label Feb 9, 2023
alexanderbez
alexanderbez approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the had work @cipherzzz 👏

@julienrbrt could you give this a quick look over too prior to merging pls?

@cipherzzz
Copy link
Contributor Author

woo-hoo! first PR! thanks guys 🍻

@julienrbrt
Copy link
Member

Thank you for all the had work @cipherzzz clap

@julienrbrt could you give this a quick look over too prior to merging pls?

Sure, cloning again the repo to check!

julienrbrt
julienrbrt requested changes Feb 13, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions, sorry to block.

simapp/simd/cmd/root.go Outdated Show resolved Hide resolved
types/result.go Outdated Show resolved Hide resolved
x/auth/tx/README.md Outdated Show resolved Hide resolved
server/cmt_cmds.go Show resolved Hide resolved
@cipherzzz
Copy link
Contributor Author

Few questions, sorry to block.

ok should be good to go now

julienrbrt
julienrbrt approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@julienrbrt julienrbrt merged commit 86eca4c into cosmos:main Feb 14, 2023
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@cipherzzz @alexanderbez @julienrbrt
feat: Integrate tendermint Block endpoints into the cli (cosmos#14659)
5b956cd 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@JeancarloBarrios JeancarloBarrios JeancarloBarrios approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

Assignees

@JeancarloBarrios JeancarloBarrios

@julienrbrt julienrbrt

Labels
C:CLI C:x/auth C:x/staking C:x/tx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a query for EndBlock msg events
5 participants
@cipherzzz @tac0turtle @alexanderbez @julienrbrt @JeancarloBarrios