chore: remove tm/math from sdk #14901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
changed the title
github-prbot
requested review from
a team,
JeancarloBarrios and
julienrbrt
and removed request for
a team
julienrbrt
reviewed
Feb 3, 2023
| if endIndex-startIndex < minSortSize { | ||
| startIndex = math.MaxInt(endIndex-minSortSize, 0) | ||
| startIndex = math.Max(endIndex-minSortSize, 0) | ||
| } |
There was a problem hiding this comment.
I don't think it's the right API. The build is failing.
There was a problem hiding this comment.
Oh may need a new release of math for the api.
There was a problem hiding this comment.
Tagged a cosmossdk.io/math v1.0.0-beta.5 👍🏾
beta.4 was from November.
samricotta
pushed a commit
that referenced
this pull request
Feb 7, 2023
19 tasks
tsenart
pushed a commit
to meka-dev/cosmos-sdk
that referenced
this pull request
Apr 12, 2023
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove a tomato from the sdk