Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Interface instead of *baseapp.MsgServiceRouter in modules #15023

Closed
alpe opened this issue Feb 14, 2023 · 1 comment · Fixed by #15035
Closed

User Interface instead of *baseapp.MsgServiceRouter in modules #15023

alpe opened this issue Feb 14, 2023 · 1 comment · Fixed by #15035
Assignees
Labels
T: Dev UX UX for SDK developers (i.e. how to call our code)

Comments

@alpe
Copy link
Contributor

alpe commented Feb 14, 2023

Summary

There is a tight coupling when the *baseapp.MsgServiceRouter type is expected in the modules. In order to make this more extendable and future proof an interface would be better.

Proposal

ibc-go and wasmd modules are using interfaces already.

// MessageRouter ADR 031 request type routing
// https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-031-msg-service.md
type MessageRouter interface {
	Handler(msg sdk.Msg) baseapp.MsgServiceHandler
}
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Feb 14, 2023
@tac0turtle tac0turtle added T: Dev UX UX for SDK developers (i.e. how to call our code) T:Sprint and removed needs-triage Issue that needs to be triaged labels Feb 14, 2023
@tac0turtle tac0turtle self-assigned this Feb 15, 2023
@tac0turtle
Copy link
Member

created a pr, in the near future this wont be needed anymore with things like adr38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants