Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix misc linter errors #15145

Merged
merged 1 commit into from
Feb 23, 2023
Merged

chore: fix misc linter errors #15145

merged 1 commit into from
Feb 23, 2023

Conversation

kocubinski
Copy link
Member

Description

Fixes linter errors causing an ❌ on the last n commits in main.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski requested a review from a team as a code owner February 23, 2023 22:21
@kocubinski kocubinski enabled auto-merge (squash) February 23, 2023 22:21
@github-prbot github-prbot requested a review from a team February 23, 2023 22:21
@github-prbot github-prbot requested review from amaury1093 and testinginprod and removed request for a team February 23, 2023 22:21
@kocubinski kocubinski merged commit 4c51b77 into main Feb 23, 2023
@kocubinski kocubinski deleted the kocubinski/linter branch February 23, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants