Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Proper use of bcrypt API #15159

Closed
wants to merge 1 commit into from

Conversation

bizk
Copy link
Contributor

@bizk bizk commented Feb 24, 2023

Description

Closes: #3129

Replaces bcrypt.GenerateFromPassword() function to pdkdf2 for keys derivation.

Implementation details:

  • Defined 10 iteration steps (cost variable) instead of 2, the minimum cost allowed by bcrypt is 4, if the desired number of cost iterations is lower (or greater), it defines it as default=10 .
  • Used SHA-256 as hashing algorithm.
  • Defined derivated key size to 24 bytes

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • [*] included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • [*] provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • [*] included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@bizk bizk requested a review from a team as a code owner February 24, 2023 19:02
@github-prbot github-prbot requested review from a team, JeancarloBarrios and likhita-809 and removed request for a team February 24, 2023 19:02
@bizk bizk closed this Feb 24, 2023
@bizk bizk deleted the feat/bcrypt-api-to-pbkdf2 branch February 24, 2023 19:03
@bizk bizk restored the feat/bcrypt-api-to-pbkdf2 branch February 24, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper use of bcrypt API
1 participant