Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean-up of #15151 #15219

Merged
merged 5 commits into from
Mar 1, 2023
Merged

chore: clean-up of #15151 #15219

merged 5 commits into from
Mar 1, 2023

Conversation

julienrbrt
Copy link
Member

Description

Some clean-up of #15151. Noticed them while backporting in #15218


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner February 28, 2023 23:20
@github-prbot github-prbot requested review from a team, tac0turtle and testinginprod and removed request for a team February 28, 2023 23:20
@@ -245,15 +245,11 @@ message Params {
repeated cosmos.base.v1beta1.Coin expedited_min_deposit = 12 [(gogoproto.nullable) = false, (amino.dont_omitempty) = true];

// burn deposits if a proposal does not meet quorum
//
// Since: cosmos-sdk 0.47
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is said on the message itself.

x/gov/migrations/v5/store.go Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, if someone is migrating from v4 -> v5 they will not have the values set out in the migration in v5, how is this handled?

@julienrbrt
Copy link
Member Author

julienrbrt commented Mar 1, 2023

thanks, if someone is migrating from v4 -> v5 they will not have the values set out in the migration in v5, how is this handled?

It is handled in migration v4 during the params migration (which happened in v0.47).
In v0.48 we only include expedited proposal and cancelling proposal, so that is only what should be there.

@julienrbrt
Copy link
Member Author

You've made me notice proposal cancel parameter were not set in v5 migration however.

@julienrbrt julienrbrt enabled auto-merge (squash) March 1, 2023 10:38
@julienrbrt julienrbrt merged commit 2f4654e into main Mar 1, 2023
@julienrbrt julienrbrt deleted the julien/clean-up-gov branch March 1, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants