-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autocli): add address validation #15449
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4d9207e
feat(autocli): add address validation
JeancarloBarrios 4b242d6
Merge branch 'main' into JeancarloBarrios/add-address-validation
JeancarloBarrios 4fccc8e
fix tests;
JeancarloBarrios 90baa55
Merge branch 'JeancarloBarrios/add-address-validation' of github.com:…
JeancarloBarrios f1c5d70
small dep fix
JeancarloBarrios 4819c71
t
JeancarloBarrios a97c791
minor fix to not fail if flagoutput is not set and default to json
JeancarloBarrios d13fba5
minor fix to not fail if flagoutput is not set and default to json
JeancarloBarrios 58deef1
fix test
JeancarloBarrios 2c1fedb
Merge branch 'main' into JeancarloBarrios/add-address-validation
JeancarloBarrios a5f0741
Merge branch 'main' into JeancarloBarrios/add-address-validation
JeancarloBarrios e3eaaa9
fix: adad integer file for failing test
JeancarloBarrios dca0e73
t
JeancarloBarrios b43eb75
init context
JeancarloBarrios c32d745
Merge branch 'main' into JeancarloBarrios/add-address-validation
JeancarloBarrios 635085d
update hubl
JeancarloBarrios 12c83e9
Merge branch 'main' into JeancarloBarrios/add-address-validation
JeancarloBarrios 4acc110
Merge branch 'main' into JeancarloBarrios/add-address-validation
JeancarloBarrios eb7393f
added dependencies
JeancarloBarrios 74c56e8
Merge branch 'main' into JeancarloBarrios/add-address-validation
julienrbrt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add docs that client v2 only supports bech32 here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Marco sorry for the question, but where exactly do you envision this in the doc should I create a new category for the flags?