Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocli): add json file parsing support #15451

Merged
merged 15 commits into from
Mar 23, 2023

Conversation

JeancarloBarrios
Copy link
Contributor

Description

Closes: #13288


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Mar 18, 2023
return j.jsonUnmarshalOptions.Unmarshal([]byte(s), j.message)
var messageBytes []byte
if isJsonFileRegex.MatchString(s) {
jsonFile, err := os.Open(s)

Check failure

Code scanning / gosec

Potential file inclusion via variable

Potential file inclusion via variable
@JeancarloBarrios JeancarloBarrios marked this pull request as ready for review March 21, 2023 14:18
@JeancarloBarrios JeancarloBarrios requested a review from a team as a code owner March 21, 2023 14:18
@github-actions

This comment has been minimized.

@github-prbot github-prbot requested review from a team, kocubinski and testinginprod and removed request for a team March 21, 2023 14:19
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@JeancarloBarrios JeancarloBarrios enabled auto-merge (squash) March 23, 2023 19:47
@JeancarloBarrios JeancarloBarrios merged commit b44caab into main Mar 23, 2023
@JeancarloBarrios JeancarloBarrios deleted the JeancarloBarrios/add-json-file-support branch March 23, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoCLI support for JSON files
4 participants