Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use app config configurator for removing boilerplate #15499

Merged
merged 6 commits into from
Mar 22, 2023

Conversation

julienrbrt
Copy link
Member

Description

Small refactors of app configs to use the configurator, as it is more readable.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@julienrbrt
Copy link
Member Author

@julienrbrt your pull request is missing a changelog!

Hey bot! My PR is in draft :/

@github-actions github-actions bot added C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:orm C:Rosetta Issues and PR related to Rosetta C:Store C:x/circuit C:x/tx C:x/upgrade labels Mar 21, 2023
@github-actions github-actions bot removed C:Confix Issues and PR related to Confix C:CLI C:x/upgrade C:orm labels Mar 21, 2023
@github-actions github-actions bot removed C:x/circuit C:Cosmovisor Issues and PR related to Cosmovisor C:Store C:Hubl Tool: Hubl labels Mar 21, 2023
@github-actions github-actions bot added C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Rosetta Issues and PR related to Rosetta C:x/circuit C:x/upgrade labels Mar 21, 2023
@julienrbrt julienrbrt marked this pull request as ready for review March 21, 2023 17:35
@julienrbrt julienrbrt requested a review from a team as a code owner March 21, 2023 17:35
@github-prbot github-prbot requested review from a team, aaronc and alexanderbez and removed request for a team March 21, 2023 17:36
@julienrbrt julienrbrt enabled auto-merge (squash) March 21, 2023 19:02
@julienrbrt julienrbrt enabled auto-merge (squash) March 21, 2023 19:03
@julienrbrt julienrbrt merged commit c77bcc2 into main Mar 22, 2023
@julienrbrt julienrbrt deleted the julien/app-config-simplify branch March 22, 2023 06:29
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants