Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable strict gofumpt #15579

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 28, 2023

Description

Works towards: #15546

This PR makes an atomic change towards #15546. In #15546, I had the module path specified, but we've got many module paths, so I've left that as default. This PR mainly removes type declarations from variables / parameters that already have a type. We can close it if not desired.

Since this doesn't affect logic, I've skipped making a changelog entry.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner March 28, 2023 17:23
@github-prbot github-prbot requested review from a team, aaronc and alexanderbez and removed request for a team March 28, 2023 17:23
@faddat faddat changed the title enable strict gofumpt chore: enable strict gofumpt Mar 28, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you!

@julienrbrt julienrbrt changed the title chore: enable strict gofumpt style: enable strict gofumpt Mar 28, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) March 28, 2023 18:48
@julienrbrt julienrbrt merged commit 37ba888 into cosmos:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants