Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(group): move ValidateBasic logic to msgServer #15785

Merged
merged 22 commits into from
Apr 18, 2023
Merged

refactor(group): move ValidateBasic logic to msgServer #15785

merged 22 commits into from
Apr 18, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Apr 11, 2023 •
edited

Description

Closes: #15648

This PR ended up refactoring and fixing group CLI tests and deduplicating group e2e tests (#15785 (comment)).

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the title refactor(group): moveValidateBasic logic to msgServer refactor(group): move ValidateBasic logic to msgServer Apr 11, 2023
@julienrbrt julienrbrt mentioned this pull request Apr 11, 2023
Closed
19 tasks
@github-actions github-actions bot added the C:CLI label Apr 14, 2023
@julienrbrt julienrbrt marked this pull request as ready for review April 17, 2023 15:34
@julienrbrt julienrbrt requested a review from a team as a code owner April 17, 2023 15:34
@github-prbot github-prbot requested review from a team, kocubinski and likhita-809 and removed request for a team April 17, 2023 15:34
@julienrbrt julienrbrt marked this pull request as draft April 17, 2023 16:03
@julienrbrt julienrbrt marked this pull request as ready for review April 17, 2023 20:31
@github-prbot github-prbot requested a review from a team April 17, 2023 20:31
tac0turtle
tac0turtle approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

likhita-809
likhita-809 reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like e2e tests are failing. Can you fix them @julienrbrt

x/group/keeper/msg_server_test.go Outdated Show resolved Hide resolved
@julienrbrt
Copy link
Member Author

looks like e2e tests are failing. Can you fix them @julienrbrt

Yes, deduplicating them 👍🏾

@julienrbrt
Copy link
Member Author

julienrbrt commented Apr 18, 2023 •
edited

So, learning from this deep dive in testing (cli and e2e):

  • Our tx e2e tests are duplicating our message server tests and cli tests and those should be removed, these e2e tests might end up just being e2e query tests after the deduplication.
  • Many CLI tests (x/**/client/cli/*_test.go) in the SDK are actually testing nothing, they are not executing the command (!!!), this is fixed for group here, but we need to basically look at all those tests in the SDK
  • Our message server tests are pretty good

@julienrbrt julienrbrt mentioned this pull request Apr 18, 2023
Closed
@julienrbrt julienrbrt added this pull request to the merge queue Apr 18, 2023
Merged via the queue into main with commit 10d7d15 Apr 18, 2023
48 checks passed
@julienrbrt julienrbrt deleted the julien/validate-group branch April 18, 2023 14:30
@julienrbrt julienrbrt mentioned this pull request Apr 19, 2023
Closed
cool-develope pushed a commit that referenced this pull request Apr 26, 2023
@julienrbrt @tac0turtle @cool-develope
refactor(group): move ValidateBasic logic to msgServer (#15785)
2f425cc 
Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees

@atheeshp atheeshp

@likhita-809 likhita-809

Labels
C:CLI C:x/authz C:x/group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Epic]: ValidateBasic
4 participants
@julienrbrt @tac0turtle @likhita-809 @atheeshp