feat(x/tx): API improvements #15871
Merged
feat(x/tx): API improvements #15871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kocubinski your pull request is missing a changelog! |
github-prbot
requested review from
a team,
JeancarloBarrios and
testinginprod
and removed request for
a team
julienrbrt
approved these changes
Apr 20, 2023
aaronc
approved these changes
Apr 20, 2023
| mode := handler.Mode() | ||
| if i == 0 { | ||
| res.defaultMode = mode |
There was a problem hiding this comment.
A unit test for this would be good, even though this is likely tested indirectly in many places.
It would also be good to have test coverage defining what should happen if NewHandlerMap is called without any handlers. I'm guessing a panic would be appropriate.
alexanderbez
approved these changes
Apr 20, 2023
|
tagging |
bizk
added a commit
to Zondax/cosmos-sdk
that referenced
this pull request
Apr 25, 2023
* solved lint issues * feat(x/tx): API improvements (cosmos#15871) * refactor(baseapp): set vote info to latest votes (cosmos#15930) * refactor(staking, slashing, signing, misc): remove aliases from types/math.go (cosmos#15902) * fix(autocli): fix simapp enhancing (cosmos#15906) * fix lint on armor.go * ran make lint-fix --------- Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
github-actions bot
pushed a commit
to Zondax/cosmos-sdk
that referenced
this pull request
Apr 25, 2023
* solved lint issues * feat(x/tx): API improvements (cosmos#15871) * refactor(baseapp): set vote info to latest votes (cosmos#15930) * refactor(staking, slashing, signing, misc): remove aliases from types/math.go (cosmos#15902) * fix(autocli): fix simapp enhancing (cosmos#15906) * fix lint on armor.go * ran make lint-fix --------- Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
cool-develope
pushed a commit
that referenced
this pull request
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fork of x/tx at 0.5.1 to support #15822. Now that this is merged this needs to go to main for #15873 to pass.
This should probably be tagged 0.6.1.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change