refactor!: use KVStoreService and context.Context in x/bank #15891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Simulations
C:x/auth
C:x/authz
C:x/distribution
facundomedica
changed the title
facundomedica
changed the title
github-prbot
requested review from
a team,
mark-rushakoff and
samricotta
and removed request for
a team
tac0turtle
reviewed
Apr 25, 2023
tac0turtle
reviewed
Apr 25, 2023
| @@ -12,7 +14,7 @@ import ( | |||
| // | |||
| // TODO: Instead of using the mint module account, which has the | |||
| // permission of minting, create a "faucet" account. (@fdymylja) | |||
| func FundAccount(bankKeeper bankkeeper.Keeper, ctx sdk.Context, addr sdk.AccAddress, amounts sdk.Coins) error { | |||
| func FundAccount(ctx context.Context, bankKeeper bankkeeper.Keeper, addr sdk.AccAddress, amounts sdk.Coins) error { | |||
There was a problem hiding this comment.
changelog for this as well, it might be used by others
There was a problem hiding this comment.
This changelog entry is still missing.
There was a problem hiding this comment.
I misread, now I've added:
`NewKeeper` now takes a `KVStoreService` instead of a `StoreKey` and methods in the `Keeper` now take a `context.Context` instead of a `sdk.Context`. Also `FundAccount` and `FundModuleAccount` from the `testutil` package accept a `context.Context` instead of a `sdk.Context`, and it's position was moved to the first place.
tac0turtle
reviewed
Apr 25, 2023
julienrbrt
approved these changes
Apr 25, 2023
x/bank/keeper/send.go
Outdated
| @@ -134,7 +135,8 @@ func (k BaseSendKeeper) InputOutputCoins(ctx sdk.Context, input types.Input, out | |||
| return err | |||
| } | |||
|
|
|||
| ctx.EventManager().EmitEvent( | |||
| c := sdk.UnwrapSDKContext(ctx) | |||
There was a problem hiding this comment.
nit, sdkCtx is usually how we call it.
x/bank/keeper/send.go
Outdated
| @@ -249,7 +252,8 @@ func (k BaseSendKeeper) subUnlockedCoins(ctx sdk.Context, addr sdk.AccAddress, a | |||
| } | |||
| } | |||
|
|
|||
| ctx.EventManager().EmitEvent( | |||
| c := sdk.UnwrapSDKContext(ctx) | |||
cool-develope
pushed a commit
that referenced
this pull request
Apr 26, 2023
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are still using
runtime.KVStoreAdapterin cases we useprefix.Store.Also because there were a couple of functions that had the context as the 2nd argument, now that it's a context.Context the linter picked it up as an error, so there are a lot of changes like this:
Ref: #14683
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change