Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(math)!: remove aliases in math #16040

Merged
merged 6 commits into from
May 7, 2023
Merged

refactor(math)!: remove aliases in math #16040

merged 6 commits into from
May 7, 2023

Conversation

tac0turtle
Copy link
Member

Description

ref #14405

removes some unused aliases from math.go


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review May 5, 2023 11:12
@tac0turtle tac0turtle requested a review from a team as a code owner May 5, 2023 11:12
@github-prbot github-prbot requested review from a team, JeancarloBarrios and atheeshp and removed request for a team May 5, 2023 11:12
CHANGELOG.md Outdated Show resolved Hide resolved
MaxDec = sdkmath.LegacyMaxDec
DecEq = sdkmath.LegacyDecEq
DecApproxEq = sdkmath.LegacyDecApproxEq
NewDecWithPrec = sdkmath.LegacyNewDecWithPrec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it still here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its still used in countless places, this pr is more about removing some unused and some minimally used variables

@julienrbrt julienrbrt changed the title refactor(math): remove aliases in math refactor(math)!: remove aliases in math May 5, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
@julienrbrt julienrbrt added this pull request to the merge queue May 7, 2023
Merged via the queue into main with commit 044fe13 May 7, 2023
49 checks passed
@julienrbrt julienrbrt deleted the marko/14405_remove branch May 7, 2023 17:28
rllola pushed a commit to Zondax/cosmos-sdk that referenced this pull request May 11, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants