Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Start DRY'ing filtered paginate code #16099

Merged
merged 17 commits into from May 15, 2023
Merged

refactor: Start DRY'ing filtered paginate code #16099

merged 17 commits into from May 15, 2023

Commits on May 11, 2023

  1. Start DRY'ing filtered paginate code

    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    a5b152f View commit details
    Browse the repository at this point in the history

  2. Move conditional

    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    c26c271 View commit details
    Browse the repository at this point in the history

  3. Dedup core loop

    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    338f416 View commit details
    Browse the repository at this point in the history

  4. delete unnecessary var eliminates

    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    652d9d2 View commit details
    Browse the repository at this point in the history

  5. Revert "delete unnecessary var eliminates" 

    This reverts commit 652d9d2.
    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    2100a7a View commit details
    Browse the repository at this point in the history

  6. Revert "Dedup core loop" 

    This reverts commit 338f416.
    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    7789983 View commit details
    Browse the repository at this point in the history

  7. Revert "Move conditional" 

    This reverts commit c26c271.
    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    0f46b6a View commit details
    Browse the repository at this point in the history

  8. de-dup a smaller set of loop

    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    a3a998d View commit details
    Browse the repository at this point in the history

  9. Add a common PageRequest cleanupFn

    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    517b3f8 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into dev/filtered_paginate_cleanup

    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    8d42944 View commit details
    Browse the repository at this point in the history

  11. Apply same dedup to generic paginate

    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    fd317f9 View commit details
    Browse the repository at this point in the history

  12. Apply same ideas to main paginate query

    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    cab4b23 View commit details
    Browse the repository at this point in the history

  13. One more paginate instance cleanup

    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    4c767e4 View commit details
    Browse the repository at this point in the history

  14. Make Jacob happy (aka gofumpt)

    @ValarDragon
    ValarDragon committed May 11, 2023
    Configuration menu
    Copy the full SHA
    8478446 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Update types/query/pagination.go 

    Co-authored-by: testinginprod <98415576+testinginprod@users.noreply.github.com>
    @ValarDragon @testinginprod
    ValarDragon and testinginprod committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e0971e2 View commit details
    Browse the repository at this point in the history

  2. Apply code comment defaults

    @ValarDragon
    ValarDragon committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1e64cd2 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. Fix linter typo

    @ValarDragon
    ValarDragon committed May 13, 2023
    Configuration menu
    Copy the full SHA
    abfde46 View commit details
    Browse the repository at this point in the history