refactor: remove dependencies x/auth -> x/genutil, x/gov #16423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
mark-rushakoff and
facundomedica
and removed request for
a team
kocubinski
changed the title
julienrbrt
reviewed
Jun 6, 2023
x/genutil/client/cli/genaccount.go
Outdated
| // to be added for the account, `appendAcct` updates the account if already exists. | ||
| // `vestingStart, vestingEnd and vestingAmtStr` respectively are the schedule start time, end time (unix epoch) | ||
| // and coins to be appended to the account already in the genesis.json file. | ||
| func addGenesisAccount( |
There was a problem hiding this comment.
This should be public and we should indeed mention it moved here.
There was a problem hiding this comment.
Ok, maybe I'll move it to a helpers package too then.
alexanderbez
approved these changes
Jun 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Advances #13025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a straightforward refactor removing x/genutil as a dependency of x/auth. We now have an acyclic
x/genutil -> x/auth, x/govinstead of cyclicx/auth <-> x/genutil, x/govin the dependency graph.x/auth/helpers.AddGenesisAccountto an unexported fn in thex/genutil/client/clipackage. No usages in the SDK, but technically this is breaking. Should we place it somewhere else and keep it exported?Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change