fix(hubl): revert f235aae

[julienrbrt]

Description

Closes: #16533

reverts f235aae.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[tac0turtle]

what is the reason for this revert, do we know why its broken?

[julienrbrt]

what is the reason for this revert, do we know why its broken?

See the issue. It breaks hubl currently because apps do not support reflection v1.

[tac0turtle]

could we do something that new apps use v1 and old apps use v1alpha. I think its good to try to migrate users to v1 instead of keeping them on v1alpha

[julienrbrt]

could we do something that new apps use v1 and old apps use v1alpha. I think its good to try to migrate users to v1 instead of keeping them on v1alpha

I'll add a fallback here then.

[julienrbrt]

Can't convert to draft on a phone, I'll do it when I grab my laptop.

[julienrbrt]

could we do something that new apps use v1 and old apps use v1alpha. I think its good to try to migrate users to v1 instead of keeping them on v1alpha

So I have looked a bit more at this and I do not think it is useful, using grpc reflection like that is a fallback for apps that do not support cosmos.reflection.v1 endpoints, so new apps will not have this problem anyway.
Is that a good assumption @aaronc?

[tac0turtle]

i dont quite follow, if its not a problem with new chains then why revert?

[julienrbrt]

i dont quite follow, if its not a problem with new chains then why revert?

Because it is a problem with chains that support only grpc relfection v1alpha1 and not the cosmos.reflection.v1.
No chains support grpc reflection v1, so this is why imho we do not need a fallback but simply revert, as if a chain supports cosmos.reflection.v1, we use it instead of grpc reflection v1alpha (so v1alpha1 is already the fallback).

[tac0turtle]

im leaning more towards leaving this and we can backport something for hubl in particular for older chains. It would be nice to use v1 instead here, otherwise we create an issue and add tech debt for future cleanup

[julienrbrt]

im leaning more towards leaving this and we can backport something for hubl in particular for older chains. It would be nice to use v1 instead here, otherwise we create an issue and add tech debt for future cleanup

Right, this makes sense, reverted for hubl only here. Hubl will any use cosmos.reflection.v1 for chains that use grpc reflection v1.

[tac0turtle]

utACK

[julienrbrt]

Hubl works again from this merge commit (822e715):

$ hubl version
hubl version: v0.0.0-20230615125140-822e71585288

[bizk]

Amazing!