Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collections): implement appmodule.HasGenesis interface #17021

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

julienrbrt
Copy link
Member

Description

ORM implements the appmodule.HasGenesis interface, but collections not yet, it is only missing the app wiring methods of the interface. This PR adds support for it.

https://github.com/cosmos/cosmos-sdk/blob/0ce4990689002daa625208d4fd5e8b5186e4739c/core/appmodule/genesis.go#L10:L23

https://github.com/cosmos/cosmos-sdk/blob/6afece635cef9f8e044a04ce67d06e55ca300249/orm/model/ormdb/module.go#L215:L217


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner July 17, 2023 09:21
@github-prbot github-prbot requested review from a team, tac0turtle and testinginprod and removed request for a team July 17, 2023 09:21
@julienrbrt julienrbrt marked this pull request as draft July 17, 2023 09:48
@julienrbrt julienrbrt marked this pull request as ready for review July 17, 2023 09:56
@github-prbot github-prbot requested a review from a team July 17, 2023 09:56
@julienrbrt julienrbrt removed the request for review from a team July 17, 2023 10:17
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is all which is needed then it looks good to me!

@julienrbrt
Copy link
Member Author

if this is all which is needed then it looks good to me!

Not too sure yet, I am trying to implement it here: cosmosregistry/example#18, but getting some errors still.

@julienrbrt julienrbrt added this pull request to the merge queue Jul 24, 2023
Merged via the queue into main with commit 2102074 Jul 24, 2023
51 checks passed
@julienrbrt julienrbrt deleted the julien/genesis-handler-collections branch July 24, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants