fix(rpc): change the default json-rpc listen address to localhost #17470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
changed the title
mmsqe
changed the title
github-prbot
requested review from
a team,
facundomedica and
atheeshp
and removed request for
a team
julienrbrt
reviewed
Aug 21, 2023
There was a problem hiding this comment.
somewhat related: #13778
For naming consistency with the above, should not we set it to localhost instead of 127.0.0.1?
github-actions
bot
added
Type: Build
and removed
C:Confix
to avoid open to public by default
julienrbrt
reviewed
Aug 23, 2023
CHANGELOG.md
Outdated
| @@ -49,6 +49,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| ### Bug Fixes | |||
|
|
|||
| * (types) [#16583](https://github.com/cosmos/cosmos-sdk/pull/16583), [#17372](https://github.com/cosmos/cosmos-sdk/pull/17372) Add `MigrationModuleManager` to handle migration of upgrade module before other modules, ensuring access to the updated context with consensus parameters within the same block that executes the migration. | |||
| * (rpc) [#17470](https://github.com/cosmos/cosmos-sdk/pull/17470) Avoid open 0.0.0.0 to public by default and add `listen-ip-address` argument for `testnet init-files` cmd. | |||
There was a problem hiding this comment.
imho, this isn't a bug. could we have this under improvement?
julienrbrt
approved these changes
Aug 23, 2023
tac0turtle
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid open to public by default
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change