Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/gov): add min_stake_to_vote parameter #18186

Closed
wants to merge 1 commit into from

Conversation

julienrbrt
Copy link
Member

Description

A-11

Cannot be backported to v0.47, but a workaround can be an ante handler.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think we should add this parameter. if this is related to gov tallying, id say we say wont fix now but will in the near future.

@julienrbrt julienrbrt closed this Oct 20, 2023
@julienrbrt
Copy link
Member Author

julienrbrt commented Oct 20, 2023

Closed as per above, we may keep the feature later this year if gov gets refactored when adding other features

@julienrbrt julienrbrt reopened this Nov 28, 2023
@julienrbrt
Copy link
Member Author

julienrbrt commented Nov 28, 2023

Re-opening given the x/gov work. I'll fix the conflicts later. Re-opening now to not forget.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Feb 18, 2024
@julienrbrt
Copy link
Member Author

julienrbrt commented Feb 18, 2024

Voting will become more expensive if we implement this. Are we going through with it or skip? That was a small dos vector to allow anyone to vote. If yes, I'll finish this.

@julienrbrt julienrbrt removed the Stale label Feb 18, 2024
@alexanderbez
Copy link
Contributor

Voting will become more expensive if we implement this. Are we going through with it or skip? That was a small dos vector to allow anyone to vote. If yes, I'll finish this.

I think this needs more community buy-in and discussion before we proceed with such a change.

@julienrbrt
Copy link
Member Author

We've discussed this in our stand-up and we fix the dos issue in another way, without requiring an extra iteration while voting and tallying.

@julienrbrt julienrbrt closed this Feb 22, 2024
@julienrbrt julienrbrt deleted the julien/gov-min-stake branch February 22, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants