-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/gov): add min_stake_to_vote
parameter
#18186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think we should add this parameter. if this is related to gov tallying, id say we say wont fix now but will in the near future.
Closed as per above, we may keep the feature later this year if gov gets refactored when adding other features |
Re-opening given the x/gov work. I'll fix the conflicts later. Re-opening now to not forget. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Voting will become more expensive if we implement this. Are we going through with it or skip? That was a small dos vector to allow anyone to vote. If yes, I'll finish this. |
I think this needs more community buy-in and discussion before we proceed with such a change. |
We've discussed this in our stand-up and we fix the dos issue in another way, without requiring an extra iteration while voting and tallying. |
Description
A-11
Cannot be backported to v0.47, but a workaround can be an ante handler.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change