chore!: skip addDenomReverseIndex in bank v3 migration #19266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoke
approved these changes
Jan 26, 2024
|
Hey folks, I checked this and it looks like it will break |
|
Hey, I appreciate the input! Could you elaborate a bit more? I did not understand this part:
I don't understand what you mean by That EDIT: |
The query would return incomplete and misleading data since the underlying index that powers it was not populated during migration due to being prohibitively resource and time intensive on cosmoshub-4. Writing to the underlying index was also disabled, except in the case of calls to initBalances (only happens on genesis/restart). It is recommended that an external indexer is used for querying this data.
MSalopek
force-pushed
the
masa/v47-skip-bank-rev-index-migration
branch
from
418bb4a
to
e39021d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR skips running
addDenomReverseIndexinbank/v3migration.This operation was prohibitively expensive to run on the Cosmos Hub (required 128GB RAM) and took 5h to complete.
After consulting with the cosmos-sdk core team, it was deemed this migration is safe to skip as whitnessed by changes on osmosis' fork:
The
DenomOwnersquery that used the underlying index was disabled to avoid returning incomplete information (since the index would not contain all denom owners but only those who with recent transfers):DenomOwnersquery and stop populating the reverse index)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...