Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove schema go.mod replaces #20914

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jul 9, 2024

Description

This is a small follow-up to #20647 to remove all the go.mod replace directives added there.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Dependency Updates
    • Updated cosmossdk.io/schema to version v0.1.1 across multiple modules for improved compatibility and functionality.
    • Removed unnecessary replace directives for cosmossdk.io/schema to streamline dependencies.

Copy link
Contributor

coderabbitai bot commented Jul 9, 2024

Walkthrough

Walkthrough

The primary change involves updating the version of the cosmossdk.io/schema dependency from v0.0.0 to v0.1.1 across multiple Go modules. This update includes the removal of the replace directive for cosmossdk.io/schema in the respective go.mod files, effectively streamlining the dependency management within the project.

Changes

Files/Directories Change Summary
client/v2/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
server/v2/cometbft/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1.
server/v2/go.mod Removed cosmossdk.io/schema import path and replace directive.
simapp/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
tests/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/accounts/defaults/lockup/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1.
x/accounts/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/auth/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/authz/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed local replacement.
x/bank/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/circuit/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/consensus/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/distribution/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/epochs/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/evidence/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/feegrant/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/gov/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/group/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/mint/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/nft/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/params/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/protocolpool/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/slashing/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/staking/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.
x/upgrade/go.mod Updated cosmossdk.io/schema from v0.0.0 to v0.1.1, removed replace directive.

Possibly related issues


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4857ea1 and 797d5f4.

Files ignored due to path filters (26)
  • client/v2/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • server/v2/cometbft/go.sum is excluded by !**/*.sum
  • simapp/go.sum is excluded by !**/*.sum
  • simapp/v2/go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/lockup/go.sum is excluded by !**/*.sum
  • x/accounts/go.sum is excluded by !**/*.sum
  • x/auth/go.sum is excluded by !**/*.sum
  • x/authz/go.sum is excluded by !**/*.sum
  • x/bank/go.sum is excluded by !**/*.sum
  • x/circuit/go.sum is excluded by !**/*.sum
  • x/consensus/go.sum is excluded by !**/*.sum
  • x/distribution/go.sum is excluded by !**/*.sum
  • x/epochs/go.sum is excluded by !**/*.sum
  • x/evidence/go.sum is excluded by !**/*.sum
  • x/feegrant/go.sum is excluded by !**/*.sum
  • x/gov/go.sum is excluded by !**/*.sum
  • x/group/go.sum is excluded by !**/*.sum
  • x/mint/go.sum is excluded by !**/*.sum
  • x/nft/go.sum is excluded by !**/*.sum
  • x/params/go.sum is excluded by !**/*.sum
  • x/protocolpool/go.sum is excluded by !**/*.sum
  • x/slashing/go.sum is excluded by !**/*.sum
  • x/staking/go.sum is excluded by !**/*.sum
  • x/upgrade/go.sum is excluded by !**/*.sum
Files selected for processing (27)
  • client/v2/go.mod (2 hunks)
  • go.mod (2 hunks)
  • server/v2/cometbft/go.mod (2 hunks)
  • server/v2/go.mod (1 hunks)
  • simapp/go.mod (2 hunks)
  • simapp/v2/go.mod (2 hunks)
  • tests/go.mod (2 hunks)
  • x/accounts/defaults/lockup/go.mod (2 hunks)
  • x/accounts/go.mod (2 hunks)
  • x/auth/go.mod (2 hunks)
  • x/authz/go.mod (2 hunks)
  • x/bank/go.mod (2 hunks)
  • x/circuit/go.mod (2 hunks)
  • x/consensus/go.mod (2 hunks)
  • x/distribution/go.mod (2 hunks)
  • x/epochs/go.mod (2 hunks)
  • x/evidence/go.mod (2 hunks)
  • x/feegrant/go.mod (2 hunks)
  • x/gov/go.mod (2 hunks)
  • x/group/go.mod (2 hunks)
  • x/mint/go.mod (2 hunks)
  • x/nft/go.mod (2 hunks)
  • x/params/go.mod (2 hunks)
  • x/protocolpool/go.mod (2 hunks)
  • x/slashing/go.mod (2 hunks)
  • x/staking/go.mod (2 hunks)
  • x/upgrade/go.mod (2 hunks)
Files skipped from review due to trivial changes (8)
  • go.mod
  • server/v2/cometbft/go.mod
  • server/v2/go.mod
  • x/feegrant/go.mod
  • x/mint/go.mod
  • x/nft/go.mod
  • x/params/go.mod
  • x/protocolpool/go.mod
Additional context used
Path-based instructions (1)
tests/go.mod (1)

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

Additional comments not posted (19)
x/consensus/go.mod (1)

29-29: Updated dependency version.

The version of cosmossdk.io/schema has been updated to v0.1.1.

x/staking/go.mod (1)

173-173: Updated dependency version.

The version of cosmossdk.io/schema has been updated to v0.1.1.

x/auth/go.mod (1)

41-41: Updated dependency version.

The version of cosmossdk.io/schema has been updated to v0.1.1.

x/bank/go.mod (1)

170-170: Updated dependency version.

The version of cosmossdk.io/schema has been updated to v0.1.1.

x/authz/go.mod (1)

171-171: Dependency Update: Added cosmossdk.io/schema v0.1.1.

The cosmossdk.io/schema dependency has been added with version v0.1.1. This aligns with the project's objective to use the standard version specified.

x/evidence/go.mod (1)

31-31: Dependency Update: Added cosmossdk.io/schema v0.1.1.

The cosmossdk.io/schema dependency has been added with version v0.1.1. This aligns with the project's objective to use the standard version specified.

x/epochs/go.mod (1)

168-168: Dependency Update: Added cosmossdk.io/schema v0.1.1.

The cosmossdk.io/schema dependency has been added with version v0.1.1. This aligns with the project's objective to use the standard version specified.

x/slashing/go.mod (1)

33-33: Dependency Update: Added cosmossdk.io/schema v0.1.1.

The cosmossdk.io/schema dependency has been added with version v0.1.1. This aligns with the project's objective to use the standard version specified.

x/circuit/go.mod (1)

27-27: Dependency version update approved.

The version of cosmossdk.io/schema has been updated to v0.1.1. This change aligns with the PR objective.

x/distribution/go.mod (1)

33-33: Dependency version update approved.

The version of cosmossdk.io/schema has been updated to v0.1.1. This change aligns with the PR objective.

x/gov/go.mod (1)

174-174: Dependency version update approved.

The version of cosmossdk.io/schema has been updated to v0.1.1. This change aligns with the PR objective.

x/accounts/defaults/lockup/go.mod (1)

22-22: Dependency version update approved.

The version of cosmossdk.io/schema has been updated to v0.1.1. This change aligns with the PR objective.

x/accounts/go.mod (1)

25-25: LGTM! Verify dependency compatibility.

The addition of cosmossdk.io/schema v0.1.1 as an indirect dependency looks good.

Please ensure that this version is compatible with the rest of the module.

client/v2/go.mod (1)

174-174: LGTM! Verify dependency compatibility.

The addition of cosmossdk.io/schema v0.1.1 as an indirect dependency looks good.

Please ensure that this version is compatible with the rest of the module.

x/group/go.mod (1)

46-46: LGTM! Verify dependency compatibility.

The addition of cosmossdk.io/schema v0.1.1 as an indirect dependency looks good.

Please ensure that this version is compatible with the rest of the module.

x/upgrade/go.mod (1)

47-47: LGTM! Verify dependency compatibility.

The addition of cosmossdk.io/schema v0.1.1 as an indirect dependency looks good.

Please ensure that this version is compatible with the rest of the module.

tests/go.mod (1)

67-67: LGTM!

The dependency version for cosmossdk.io/schema has been correctly updated to v0.1.1.

simapp/go.mod (1)

63-63: LGTM!

The dependency version for cosmossdk.io/schema has been correctly updated to v0.1.1.

simapp/v2/go.mod (1)

65-65: LGTM!

The dependency version for cosmossdk.io/schema has been correctly updated to v0.1.1.

@aaronc aaronc added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 9d80739 Jul 9, 2024
69 checks passed
@aaronc aaronc deleted the aaronc/schema-remove-replaces branch July 9, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants