ci: set up x/acounts/multisig #20934

facundomedica · 2024-07-11T08:06:18Z

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

Chores
- Added scheduling configurations for multisig and lockup directories for weekly dependabot updates.
- Updated paths for PR labeling for multisig and lockup within the x/accounts directory.
- Added changelog templates for multisig and lockup modules.
- Introduced SonarQube configuration for multisig and lockup modules.
Refactor
- Reordered import statements in several test files for consistency.
Documentation
- Corrected a punctuation error in a comment within testutil/types.go.
Tests
- Added new test job for x/accounts/defaults/multisig in CI workflow.

coderabbitai · 2024-07-11T08:06:26Z

Walkthrough

The recent changes introduce scheduling configurations for Dependabot and path updates for labeler settings, add new test jobs for specific directories, and ensure SonarQube configuration files for the multisig and lockup modules. Additionally, import statements were reordered in several test files, and a minor punctuation error in a comment was corrected. These updates optimize the CI/CD pipeline and improve the project’s maintainability without altering exported or public entities.

Changes

File(s)	Change Summary
`.github/dependabot.yml`	Added scheduling for `multisig` and `lockup` directories to trigger weekly on Wednesdays
`.github/pr_labeler.yml`	Added new paths for `multisig` and `lockup` within the `x/accounts` directory
`.github/workflows/test.yml`	Added job `test-x-accounts-multisig` for testing the `x/accounts/defaults/multisig` directory
`x/accounts/defaults/{multisig,lockup}/CHANGELOG.md`	Introduced templates for maintaining changelogs for `multisig` and `lockup` modules
`x/accounts/defaults/{multisig,lockup}/sonar-project.properties`	Added SonarQube configuration files for `multisig` and `lockup` modules
`x/accounts/defaults/lockup/{continuous_locking_account_test.go,delayed_locking...}_test.go`	Reordered import statements for `sdk "github.com/cosmos/cosmos-sdk/types"` in multiple test files
`testutil/types.go`	Corrected a punctuation error in a comment

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ab6400f and f2e4afd.

Files selected for processing (7)

.github/dependabot.yml (1 hunks)
.github/pr_labeler.yml (1 hunks)
.github/workflows/test.yml (2 hunks)
x/accounts/defaults/lockup/CHANGELOG.md (1 hunks)
x/accounts/defaults/lockup/sonar-project.properties (1 hunks)
x/accounts/defaults/multisig/CHANGELOG.md (1 hunks)
x/accounts/defaults/multisig/sonar-project.properties (1 hunks)

Files skipped from review due to trivial changes (5)

.github/dependabot.yml
.github/pr_labeler.yml
x/accounts/defaults/lockup/sonar-project.properties
x/accounts/defaults/multisig/CHANGELOG.md
x/accounts/defaults/multisig/sonar-project.properties

Additional context used

Path-based instructions (1)

x/accounts/defaults/lockup/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Markdownlint

x/accounts/defaults/lockup/CHANGELOG.md

26-26: null
Files should end with a single newline character

(MD047, single-trailing-newline)

Additional comments not posted (2)

.github/workflows/test.yml (2)

834-836: Ensure consistency in job naming and details.

The test-x-accounts-lockup job has been renamed, but its details remain unchanged. Verify that the renaming aligns with the overall workflow structure and naming conventions.

857-879: Review the new test-x-accounts-multisig job for correctness.

The new job for test-x-accounts-multisig follows a similar structure to the test-x-accounts-lockup job. Ensure that the steps and configurations are correct and align with the intended functionality.

coderabbitai · 2024-07-11T08:11:33Z

x/accounts/defaults/lockup/CHANGELOG.md

+
+# Changelog
+
+## [Unreleased]


Ensure the file ends with a single newline character.

According to Markdownlint, files should end with a single newline character.

+

Committable suggestion was skipped due to low confidence.

Tools

Markdownlint

26-26: null
Files should end with a single newline character

(MD047, single-trailing-newline)

julienrbrt

lgtm!

julienrbrt · 2024-07-11T08:12:22Z

x/accounts/defaults/multisig/sonar-project.properties

I think we can delete those? The job doesn't have a sonarcloud step (or we should add it)

Ok removing 👌

sontrinh16

thanks for the lockup update

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f2e4afd and b8d7b03.

Files selected for processing (4)

x/accounts/defaults/lockup/continuous_locking_account_test.go (1 hunks)
x/accounts/defaults/lockup/delayed_locking_account_test.go (1 hunks)
x/accounts/defaults/lockup/periodic_locking_account_test.go (1 hunks)
x/accounts/defaults/lockup/permanent_locking_account_test.go (1 hunks)

Files skipped from review due to trivial changes (4)

x/accounts/defaults/lockup/continuous_locking_account_test.go
x/accounts/defaults/lockup/delayed_locking_account_test.go
x/accounts/defaults/lockup/periodic_locking_account_test.go
x/accounts/defaults/lockup/permanent_locking_account_test.go

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b8d7b03 and 9d1ea0f.

Files selected for processing (1)

testutil/types.go (1 hunks)

Files skipped from review due to trivial changes (1)

testutil/types.go

.github/workflows/test.yml

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9d1ea0f and 53865b1.

Files selected for processing (1)

.github/workflows/test.yml (1 hunks)

Files skipped from review as they are similar to previous changes (1)

.github/workflows/test.yml

chore: Finish set up of x/acounts/multisig

db204e2

facundomedica assigned julienrbrt Jul 11, 2024

facundomedica requested a review from a team as a code owner July 11, 2024 08:06

github-actions bot added the Type: CI label Jul 11, 2024

missing files

f2e4afd

github-actions bot added the C:x/accounts label Jul 11, 2024

julienrbrt changed the title ~~chore: Finish set up of x/acounts/multisig~~ ci: Finish set up of x/acounts/multisig Jul 11, 2024

coderabbitai bot reviewed Jul 11, 2024

View reviewed changes

julienrbrt approved these changes Jul 11, 2024

View reviewed changes

sontrinh16 approved these changes Jul 11, 2024

View reviewed changes

remove sonar

6a13030

facundomedica enabled auto-merge July 11, 2024 09:27

lint fix

b8d7b03

coderabbitai bot reviewed Jul 11, 2024

View reviewed changes

facundomedica added 2 commits July 12, 2024 11:31

Merge branch 'main' into facu/fup-multisig-gomod

8a37b7e

Merge branch 'main' into facu/fup-multisig-gomod

f209ed9

julienrbrt disabled auto-merge July 13, 2024 09:33

kick ci

9d1ea0f

julienrbrt changed the title ~~ci: Finish set up of x/acounts/multisig~~ ci: set up of x/acounts/multisig Jul 13, 2024

julienrbrt changed the title ~~ci: set up of x/acounts/multisig~~ ci: set up x/acounts/multisig Jul 13, 2024

julienrbrt enabled auto-merge July 13, 2024 09:34

coderabbitai bot reviewed Jul 13, 2024

View reviewed changes

julienrbrt reviewed Jul 13, 2024

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

Update test.yml

53865b1

coderabbitai bot reviewed Jul 13, 2024

View reviewed changes

julienrbrt added this pull request to the merge queue Jul 13, 2024

Merged via the queue into main with commit a923e13 Jul 13, 2024
72 checks passed

julienrbrt deleted the facu/fup-multisig-gomod branch July 13, 2024 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: set up x/acounts/multisig #20934

ci: set up x/acounts/multisig #20934

facundomedica commented Jul 11, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 11, 2024 •

edited

Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot Jul 11, 2024

julienrbrt left a comment

julienrbrt Jul 11, 2024

facundomedica Jul 11, 2024

sontrinh16 left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

ci: set up x/acounts/multisig #20934

ci: set up x/acounts/multisig #20934

Conversation

facundomedica commented Jul 11, 2024 • edited by coderabbitai bot Loading

Description

Author Checklist

Reviewers Checklist

Summary by CodeRabbit

coderabbitai bot commented Jul 11, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Jul 11, 2024

Choose a reason for hiding this comment

julienrbrt left a comment

Choose a reason for hiding this comment

julienrbrt Jul 11, 2024

Choose a reason for hiding this comment

facundomedica Jul 11, 2024

Choose a reason for hiding this comment

sontrinh16 left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

facundomedica commented Jul 11, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 11, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)