R4R: Sunny/tombstone spec

[sunnya97]

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #3103 into develop will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3103      +/-   ##
===========================================
- Coverage    59.38%   59.32%   -0.07%     
===========================================
  Files          131      131              
  Lines         9862     9862              
===========================================
- Hits          5857     5851       -6     
- Misses        3632     3638       +6     
  Partials       373      373

[cwgoes]

Thanks for the spec - left comments - can we add more detail on what exactly a tombstone state means in terms of the store? e.g.

• Validator record left in store, but can never be bonded - essentially special kind of permanent "jail"
• Maximum slashing amount tracked in case multiple infractions are registered (or maybe this can be post-launch)

Also we probably want to change how we deal with unbonding delegations and redelegations a bit. Presently if we just start unbonding the validator delegators will have unbonding delegations, which can't be converted into redelegations (so they'll have to wait the full unbonding period to delegate their stake to a different validator). That seems suboptimal.

[rigelrozanski]

Tone of this document is a bit funny (ex. use of I) sounds more like ADR - content good however, few comments within

[cwgoes]

A few more comments, some first-pass comments still unaddressed I think.

Definitely in favor of the simplicity of implementation!

[cwgoes]

Bump. Anything anyone else can do to help here @sunnya97?

[jackzampolin]

I think this needs to get rebased as the tests are failing on this branch.

[melekes]

🍰

[jackzampolin]

This looks ready to merge once the lint error is fixed @sunnya97 .

WARNING: exec: "golint": executable file not found in $PATH
WARNING: exec: "ineffassign": executable file not found in $PATH
WARNING: exec: "unconvert": executable file not found in $PATH
WARNING: exec: "misspell": executable file not found in $PATH

@cwgoes and @alexanderbez can y'all approve here if the changes look good?

[cwgoes]

A few remaining minor comments.

[jackzampolin]

Is this ready to go @alexanderbez ?

[alexanderbez]

updated + approved