R4R: Withdraw commission on self bond removal #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikhofstadt
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #3163 +/- ##
===========================================
- Coverage 55.03% 55.01% -0.02%
===========================================
Files 133 133
Lines 9438 9434 -4
===========================================
- Hits 5194 5190 -4
- Misses 3924 3927 +3
+ Partials 320 317 -3 |
Codecov Report
@@ Coverage Diff @@
## cwgoes/gos-patch-1 #3163 +/- ##
=====================================================
- Coverage 55.06% 55% -0.06%
=====================================================
Files 133 133
Lines 9435 9432 -3
=====================================================
- Hits 5195 5188 -7
- Misses 3923 3927 +4
Partials 317 317 |
hendrikhofstadt
changed the title
alexanderbez
changed the title
alexanderbez
added
ready-for-review
C:x/distribution
There was a problem hiding this comment.
These changes LGTM and makes sense based upon the context of the issue. Not sure how something like this wasn't caught during simulation as it seems like a pretty common case.
In any case, this warrants a review from @cwgoes and/or @rigelrozanski.
Thanks @SLAMPER!
| @@ -119,6 +122,15 @@ func (k Keeper) takeValidatorFeePoolRewards(ctx sdk.Context, operatorAddr sdk.Va | |||
| return nil | |||
| } | |||
|
|
|||
| func (k Keeper) withdrawValidatorCommission(ctx sdk.Context, operatorAddr sdk.ValAddress) (types.FeePool, types.DecCoins) { | |||
| @@ -42,6 +42,9 @@ func (k Keeper) RemoveValidatorDistInfo(ctx sdk.Context, valAddr sdk.ValAddress) | |||
| if vdi.DelAccum.Accum.IsPositive() { | |||
| panic("Should not delete validator with unwithdrawn delegator accum") | |||
| } | |||
| if !vdi.ValCommission.IsZero() { | |||
|
@SLAMPER Please rebase on |
|
@cwgoes Did so. |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3160
Alternatively, we could also do this in
takeValidatorFeePoolRewardsFor Admin Use: