Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Make cli tests use build files #3808

Merged
merged 2 commits into from Mar 7, 2019
Merged

R4R: Make cli tests use build files #3808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
511daac
Make cli tests use build files
jaekwon Mar 5, 2019
cd7c3f2
Update PENDING.md
cwgoes Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Expand Up @@ -160,8 +160,8 @@ godocs:

test: test_unit

test_cli:
@go test -p 4 `go list github.com/cosmos/cosmos-sdk/cmd/gaia/cli_test` -tags=cli_test
test_cli: build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@go test -p 4 `go list ./cmd/gaia/cli_test/...` -tags=cli_test

test_ledger:
# First test with mock
Expand Down
2 changes: 2 additions & 0 deletions PENDING.md
View file
Open in desktop
Expand Up @@ -70,6 +70,8 @@ CLI flag.

### Gaia

* #3808 `gaiad` and `gaiacli` integration tests use ./build/ binaries.

### SDK

* \#3753 Remove no-longer-used governance penalty parameter
Expand Down
2 changes: 1 addition & 1 deletion client/lcd/test_helpers.go
View file
Open in desktop
Expand Up @@ -668,7 +668,7 @@ func doTransfer(
resp, body, recvAddr := doTransferWithGas(
t, port, seed, name, memo, pwd, addr, "", 1.0, false, true, fees,
)
require.Equal(t, http.StatusOK, resp.StatusCode, resp)
require.Equal(t, http.StatusOK, resp.StatusCode, body)

var txResp sdk.TxResponse
err := cdc.UnmarshalJSON([]byte(body), &txResp)
Expand Down