Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WithdrawValidatorCommission #3836

Merged
merged 4 commits into from Mar 12, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 8, 2019

Fix WithdrawValidatorCommission to set the validator's remaining commission correctly (i.e. taking care of the case when the remainder is zero).

ref: #3830
closes: #3837


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #3836 into develop will decrease coverage by <.01%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop    #3836      +/-   ##
===========================================
- Coverage    60.92%   60.92%   -0.01%     
===========================================
  Files          192      192              
  Lines        14323    14328       +5     
===========================================
+ Hits          8727     8729       +2     
- Misses        5027     5030       +3     
  Partials       569      569

@alexanderbez alexanderbez added the T: State Machine Breaking State machine breaking changes (impacts consensus). label Mar 8, 2019
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, given comments are addressed

types/dec_coin.go Show resolved Hide resolved
x/distribution/keeper/keeper.go Outdated Show resolved Hide resolved
@cwgoes cwgoes merged commit b316c47 into develop Mar 12, 2019
@cwgoes cwgoes deleted the bez/fix-withdraw-val-commission branch March 12, 2019 15:10
This was referenced Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/distribution distribution module related C:x/staking T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken WithdrawValidatorCommission
3 participants