Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs for mainnet #3838

Merged
merged 7 commits into from Mar 13, 2019
Merged

Update Docs for mainnet #3838

merged 7 commits into from Mar 13, 2019

Conversation

gamarin2
Copy link
Contributor

@gamarin2 gamarin2 commented Mar 8, 2019

All docs ready for mainnet.

Still waiting for recommended gas-prices to merge.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #3838 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3838   +/-   ##
========================================
  Coverage    60.92%   60.92%           
========================================
  Files          192      192           
  Lines        14323    14323           
========================================
  Hits          8727     8727           
  Misses        5027     5027           
  Partials       569      569

@jackzampolin
Copy link
Member

We should have a corresponding PR for master to ensure that the docs builds are pushed.

@gamarin2
Copy link
Contributor Author

gamarin2 commented Mar 9, 2019

Will make one as soon as this PR is R4M

@gamarin2 gamarin2 marked this pull request as ready for review March 11, 2019 18:01
@gamarin2 gamarin2 mentioned this pull request Mar 11, 2019
5 tasks
@alexanderbez
Copy link
Contributor

Left some feedback on #3855

@jackzampolin jackzampolin merged commit 5b62109 into develop Mar 13, 2019
@codecov-io
Copy link

Codecov Report

Merging #3838 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3838   +/-   ##
========================================
  Coverage    60.92%   60.92%           
========================================
  Files          192      192           
  Lines        14323    14323           
========================================
  Hits          8727     8727           
  Misses        5027     5027           
  Partials       569      569

@cwgoes cwgoes deleted the gamarin/mainnet-docs branch March 13, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants