Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to genesis #3891

Merged
merged 1 commit into from Mar 14, 2019
Merged

Fix link to genesis #3891

merged 1 commit into from Mar 14, 2019

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Mar 14, 2019

  • Closes Join Mainnet broken link #3890

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #3891 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3891      +/-   ##
===========================================
- Coverage    60.95%   60.94%   -0.02%     
===========================================
  Files          192      192              
  Lines        14360    14360              
===========================================
- Hits          8753     8751       -2     
- Misses        5033     5035       +2     
  Partials       574      574

@cwgoes cwgoes merged commit 48b6b38 into develop Mar 14, 2019
@cwgoes cwgoes deleted the sabau/3890-docs-join-mainnet branch March 14, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants