Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bcrypto.GenerateFromPassword() to mainline go x/crypto #3895

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 14, 2019

As per tendermint#3027.
This change is required for go dep -> go mod migration.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

As per tendermint#3027.
This change is required for go dep -> go mod migration.
@alessio alessio force-pushed the alessio/revert-to-mainline-gocrypto-GenerateFromPassword branch from 9aa9a02 to e34045b Compare March 14, 2019 19:15
@ebuchman
Copy link
Member

I don't think this will work - see #3129.

Does modules not support aliasing the repo? To properly fix this we'll need to move a real encryption scheme rather than abusing bcrypt like we are now. Bcrypt is for password hashing, not deriving secret keys.

@alessio alessio closed this Mar 15, 2019
@alessio alessio deleted the alessio/revert-to-mainline-gocrypto-GenerateFromPassword branch March 15, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants