Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamarin/master docs update #3922

Merged
merged 5 commits into from Mar 18, 2019
Merged

Gamarin/master docs update #3922

merged 5 commits into from Mar 18, 2019

Conversation

gamarin2
Copy link
Contributor

Closes #3908

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.

docs/gaia/delegator-guide-cli.md Outdated Show resolved Hide resolved
docs/gaia/delegator-guide-cli.md Outdated Show resolved Hide resolved
docs/gaia/delegator-guide-cli.md Outdated Show resolved Hide resolved
Co-Authored-By: gamarin2 <gautier@tendermint.com>
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #3922 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3922   +/-   ##
=======================================
  Coverage   60.83%   60.83%           
=======================================
  Files         192      192           
  Lines       14288    14288           
=======================================
  Hits         8692     8692           
  Misses       5029     5029           
  Partials      567      567

1 similar comment
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #3922 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3922   +/-   ##
=======================================
  Coverage   60.83%   60.83%           
=======================================
  Files         192      192           
  Lines       14288    14288           
=======================================
  Hits         8692     8692           
  Misses       5029     5029           
  Partials      567      567

Co-Authored-By: gamarin2 <gautier@tendermint.com>
@jackzampolin jackzampolin merged commit ce82e01 into master Mar 18, 2019
@jackzampolin jackzampolin deleted the gamarin/master-docs-update branch March 18, 2019 23:58
@alexanderbez alexanderbez mentioned this pull request Apr 3, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants