New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gamarin/master docs update #3922
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamarin2
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
March 17, 2019 13:11
cwgoes
suggested changes
Mar 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions.
Co-Authored-By: gamarin2 <gautier@tendermint.com>
Codecov Report
@@ Coverage Diff @@
## master #3922 +/- ##
=======================================
Coverage 60.83% 60.83%
=======================================
Files 192 192
Lines 14288 14288
=======================================
Hits 8692 8692
Misses 5029 5029
Partials 567 567 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3922 +/- ##
=======================================
Coverage 60.83% 60.83%
=======================================
Files 192 192
Lines 14288 14288
=======================================
Hits 8692 8692
Misses 5029 5029
Partials 567 567 |
Co-Authored-By: gamarin2 <gautier@tendermint.com>
cwgoes
approved these changes
Mar 18, 2019
jackzampolin
approved these changes
Mar 18, 2019
This was referenced Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3908
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: